* Re: [alsa-cvslog] CVS: alsa-kernel/usb usbaudio.c,1.12,1.13 ...
[not found] <E17x3I7-0005RW-00@usw-pr-cvs1.sourceforge.net>
@ 2002-10-04 7:49 ` Clemens Ladisch
2002-10-04 12:28 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Clemens Ladisch @ 2002-10-04 7:49 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: alsa-devel
Jaroslav Kysela wrote:
> Modified Files:
> usbaudio.c usbmidi.c usbmixer.c
> Log Message:
> Fixes for 2.5 USB core
> (...)
>
> +#ifndef OLD_USB
> + return 0;
> +#else
> return chip;
> +#endif
>
> (...)
>
> +#ifndef OLD_USB
> + void *ptr = dev_get_drvdata(&intf->dev);
> +#endif
IMHO a call do dev_set_drvdata(dev, chip) is missing.
Regards
Clemens
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: Re: [alsa-cvslog] CVS: alsa-kernel/usb usbaudio.c,1.12,1.13 ...
2002-10-04 7:49 ` [alsa-cvslog] CVS: alsa-kernel/usb usbaudio.c,1.12,1.13 Clemens Ladisch
@ 2002-10-04 12:28 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2002-10-04 12:28 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: Jaroslav Kysela, alsa-devel
At Fri, 04 Oct 2002 09:49:01 +0200,
Clemens Ladisch wrote:
>
> Jaroslav Kysela wrote:
>
> > Modified Files:
> > usbaudio.c usbmidi.c usbmixer.c
> > Log Message:
> > Fixes for 2.5 USB core
>
> > (...)
> >
>
> > +#ifndef OLD_USB
> > + return 0;
> > +#else
> > return chip;
> > +#endif
>
> >
> > (...)
> >
>
> > +#ifndef OLD_USB
> > + void *ptr = dev_get_drvdata(&intf->dev);
> > +#endif
>
>
> IMHO a call do dev_set_drvdata(dev, chip) is missing.
fixed now.
Takashi
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-04 12:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E17x3I7-0005RW-00@usw-pr-cvs1.sourceforge.net>
2002-10-04 7:49 ` [alsa-cvslog] CVS: alsa-kernel/usb usbaudio.c,1.12,1.13 Clemens Ladisch
2002-10-04 12:28 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox