Re: [PATCH] Change the freq limit of speaker-test

[Anssi Hannula <anssi.hannula@mbnet.fi>]

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

Takashi Iwai wrote:
> At Fri, 17 Jun 2005 21:14:48 +0300,
> Anssi Hannula wrote:
>>
>>I noticed that the speaker-test has limited sine wave frequency to 
>>50-5000 Hz. Attached patch changes that to 0-24575Hz (that's the limit 
>>at least here (x86-64) after which the freq would roll over to 0 Hz).
> 
> Does freq=0 really work?  I think this will result in zero-division.

Well, it produces the expected output (no sound) and does not crash.

> Also, atof() is better than atoi() for freq since freq is a double.
> 

OK, changed that. New patch attached.

-- 
Anssi Hannula


[-- Attachment #2: speaker-test_changelimits-atof.diff --]
[-- Type: text/x-patch, Size: 720 bytes --]

Index: speaker-test/speaker-test.c
===================================================================
RCS file: /cvsroot/alsa/alsa-utils/speaker-test/speaker-test.c,v
retrieving revision 1.8
diff -u -r1.8 speaker-test.c
--- speaker-test/speaker-test.c	3 May 2005 18:36:08 -0000	1.8
+++ speaker-test/speaker-test.c	21 Jun 2005 14:44:01 -0000
@@ -531,9 +531,9 @@
       channels = channels > 1024 ? 1024 : channels;
       break;
     case 'f':
-      freq = atoi(optarg);
-      freq = freq < 50 ? 50 : freq;
-      freq = freq > 5000 ? 5000 : freq;
+      freq = atof(optarg);
+      freq = freq < 0 ? 0 : freq;
+      freq = freq > 24575 ? 24575 : freq;
       break;
     case 'b':
       buffer_time = atoi(optarg);