Re: [PATCH] Change the freq limit of speaker-test

[Takashi Iwai <tiwai@suse.de>]

At Fri, 17 Jun 2005 21:14:48 +0300,
Anssi Hannula wrote:
> 
> Hi!
> 
> I noticed that the speaker-test has limited sine wave frequency to 
> 50-5000 Hz. Attached patch changes that to 0-24575Hz (that's the limit 
> at least here (x86-64) after which the freq would roll over to 0 Hz).

Does freq=0 really work?  I think this will result in zero-division.
I'm not sure which max value is reasonable...

Also, atof() is better than atoi() for freq since freq is a double.


Takashi


> 
> ps. I'm not subscribed, CC me when replying.
> 
> -- 
> Anssi Hannula
> 
> [2 speaker-test_changelimits.diff <text/x-patch (7bit)>]
> Index: alsa-utils/speaker-test/speaker-test.c
> ===================================================================
> RCS file: /cvsroot/alsa/alsa-utils/speaker-test/speaker-test.c,v
> retrieving revision 1.8
> diff -u -r1.8 speaker-test.c
> --- alsa-utils/speaker-test/speaker-test.c	3 May 2005 18:36:08 -0000	1.8
> +++ alsa-utils/speaker-test/speaker-test.c	17 Jun 2005 18:07:34 -0000
> @@ -532,8 +532,8 @@
>        break;
>      case 'f':
>        freq = atoi(optarg);
> -      freq = freq < 50 ? 50 : freq;
> -      freq = freq > 5000 ? 5000 : freq;
> +      freq = freq < 0 ? 0 : freq;
> +      freq = freq > 24575 ? 24575 : freq;
>        break;
>      case 'b':
>        buffer_time = atoi(optarg);


-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click