From: Mark Salazar <markTheCoder@justmyself.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@lists.sourceforge.net
Subject: Re: [es18xx.c PATCH] #1/4 for Zoom Video - resolve common vs chipset specific mixer controls
Date: Sun, 15 Jan 2006 15:30:06 -0500 [thread overview]
Message-ID: <43CAB0CE.2040602@justmyself.net> (raw)
In-Reply-To: <s5hu0ccfgu6.wl%tiwai@suse.de>
Takashi Iwai wrote:
>
>Basically, rewriting the static array and restoring it looks odd, so
>I prefer having multiple kcontrol_new arrays. (Besides, you could use
>simply NULL for the validity check.) From the readability viewpoint,
>separate arrays are better, too. The most important point is that the
>code flow is straightforward.
>
>
>Takashi
>
>
>
OK, I've tried your version of mod1 and it seems to work fine.
Also retested the patches for mods 2 & 3 ... no changes necessary.
Revised mod4 patch to follow.
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
next prev parent reply other threads:[~2006-01-15 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-26 15:44 [es18xx.c PATCH] #1/4 for Zoom Video - resolve common vs chipset specific mixer controls Mark Salazar
2005-12-26 16:07 ` Lee Revell
2005-12-26 17:36 ` Mark Salazar
2005-12-26 17:46 ` Lee Revell
2006-01-02 14:22 ` Takashi Iwai
2006-01-08 23:01 ` Mark Salazar
2006-01-09 12:13 ` Takashi Iwai
2006-01-10 0:58 ` Mark Salazar
[not found] ` <s5hu0ccfgu6.wl%tiwai@suse.de>
2006-01-15 20:30 ` Mark Salazar [this message]
2006-01-16 11:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43CAB0CE.2040602@justmyself.net \
--to=markthecoder@justmyself.net \
--cc=alsa-devel@lists.sourceforge.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox