From: Pierre Ossman <drzeus-list@drzeus.cx>
To: alsa-devel@lists.sourceforge.net
Subject: [PATCH] Remove bogus assert
Date: Wed, 25 Jan 2006 20:29:35 +0100 [thread overview]
Message-ID: <43D7D19F.9070509@drzeus.cx> (raw)
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
Freeing the global config update structure when it had been created
without any configs present caused an assertion to trigger. Since this
is a valid scenario and the assertion didn't really protect against
anything, it should simply be removed. Attached patch does exactly that.
Rgds
Pierre
[-- Attachment #2: alsa-badassert.patch --]
[-- Type: text/x-patch, Size: 336 bytes --]
--- alsa-lib-1.0.10.orig/src/conf.c 2005-10-12 18:08:53.000000000 +0200
+++ alsa-lib-1.0.10/src/conf.c 2006-01-25 20:18:30.000000000 +0100
@@ -3106,7 +3106,6 @@
unsigned int k;
assert(update);
- assert(update->count > 0 && update->finfo);
for (k = 0; k < update->count; k++)
free(update->finfo[k].name);
if (update->finfo)
next reply other threads:[~2006-01-25 19:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 19:29 Pierre Ossman [this message]
2006-01-27 11:54 ` [PATCH] Remove bogus assert Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43D7D19F.9070509@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox