[PATCH] Remove bogus assert

[PATCH] Remove bogus assert

[Pierre Ossman]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Freeing the global config update structure when it had been created
without any configs present caused an assertion to trigger. Since this
is a valid scenario and the assertion didn't really protect against
anything, it should simply be removed. Attached patch does exactly that.

Rgds
Pierre


[-- Attachment #2: alsa-badassert.patch --]
[-- Type: text/x-patch, Size: 336 bytes --]

--- alsa-lib-1.0.10.orig/src/conf.c	2005-10-12 18:08:53.000000000 +0200
+++ alsa-lib-1.0.10/src/conf.c	2006-01-25 20:18:30.000000000 +0100
@@ -3106,7 +3106,6 @@
 	unsigned int k;
 
 	assert(update);
-	assert(update->count > 0 && update->finfo);
 	for (k = 0; k < update->count; k++)
 		free(update->finfo[k].name);
 	if (update->finfo)

Re: [PATCH] Remove bogus assert

[Takashi Iwai]

At Wed, 25 Jan 2006 20:29:35 +0100,
Pierre Ossman wrote:
> 
> Freeing the global config update structure when it had been created
> without any configs present caused an assertion to trigger. Since this
> is a valid scenario and the assertion didn't really protect against
> anything, it should simply be removed. Attached patch does exactly that.
> 
> Rgds
> Pierre

Thanks, applied to CVS now.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642