From: Matthew Ranostay <mranostay@embeddedalley.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>, "Tellman, Steven" <Steven.Tellman@idt.com>
Subject: [PATCH] hda: incorrect DAC mixer on 92hd71bxxx
Date: Thu, 28 Feb 2008 17:03:36 -0500 [thread overview]
Message-ID: <47C72FB8.2070900@embeddedalley.com> (raw)
If there was two line_outs[] it would overrun into the dmic nid struct below
and create a phantom "Surround" mixer.
Signed-off-by: Matthew Ranostay <mranostay@embeddedalley.com>
---
diff -r 54a51b975975 pci/hda/patch_sigmatel.c
--- a/pci/hda/patch_sigmatel.c Thu Feb 28 12:46:32 2008 +0100
+++ b/pci/hda/patch_sigmatel.c Thu Feb 28 16:52:43 2008 -0500
@@ -246,8 +246,8 @@ static hda_nid_t stac92hd71bxx_dmux_nids
0x1c,
};
-static hda_nid_t stac92hd71bxx_dac_nids[1] = {
- 0x10, /*0x11, */
+static hda_nid_t stac92hd71bxx_dac_nids[2] = {
+ 0x10, 0x11
};
#define STAC92HD71BXX_NUM_DMICS 2
@@ -2345,10 +2345,10 @@ static int stac92xx_auto_create_multi_ou
for (i = 0; i < cfg->line_outs; i++) {
- if (!spec->multiout.dac_nids[i])
+
+ nid = spec->multiout.dac_nids[i];
+ if (!nid || nid == spec->multiout.hp_nid)
continue;
-
- nid = spec->multiout.dac_nids[i];
if (i == 2) {
/* Center/LFE */
@@ -3550,7 +3550,7 @@ again:
spec->num_pwrs = ARRAY_SIZE(stac92hd71bxx_pwr_nids);
spec->pwr_nids = stac92hd71bxx_pwr_nids;
- spec->multiout.num_dacs = 1;
+ spec->multiout.num_dacs = ARRAY_SIZE(stac92hd71bxx_dac_nids);
spec->multiout.hp_nid = 0x11;
spec->multiout.dac_nids = stac92hd71bxx_dac_nids;
next reply other threads:[~2008-02-28 22:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 22:03 Matthew Ranostay [this message]
2008-02-29 10:14 ` [PATCH] hda: incorrect DAC mixer on 92hd71bxxx Takashi Iwai
2008-02-29 12:55 ` Matthew Ranostay
2008-02-29 13:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47C72FB8.2070900@embeddedalley.com \
--to=mranostay@embeddedalley.com \
--cc=Steven.Tellman@idt.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox