From: Takashi Iwai <tiwai@suse.de>
To: Matthew Ranostay <mranostay@embeddedalley.com>
Cc: alsa-devel@alsa-project.org, "Tellman, Steven" <Steven.Tellman@idt.com>
Subject: Re: [PATCH] hda: incorrect DAC mixer on 92hd71bxxx
Date: Fri, 29 Feb 2008 11:14:24 +0100 [thread overview]
Message-ID: <s5hmypkqdbz.wl%tiwai@suse.de> (raw)
In-Reply-To: <47C72FB8.2070900@embeddedalley.com>
At Thu, 28 Feb 2008 17:03:36 -0500,
Matthew Ranostay wrote:
>
> If there was two line_outs[] it would overrun into the dmic nid struct below
> and create a phantom "Surround" mixer.
My bad. But isn't the fix below simpler?
thanks,
Takashi
---
diff -r 54a51b975975 pci/hda/patch_sigmatel.c
--- a/pci/hda/patch_sigmatel.c Thu Feb 28 12:46:32 2008 +0100
+++ b/pci/hda/patch_sigmatel.c Fri Feb 29 11:17:54 2008 +0100
@@ -2344,7 +2344,7 @@ static int stac92xx_auto_create_multi_ou
unsigned int wid_caps, pincap;
- for (i = 0; i < cfg->line_outs; i++) {
+ for (i = 0; i < cfg->line_outs && i < spec->multiout.num_dacs; i++) {
if (!spec->multiout.dac_nids[i])
continue;
next prev parent reply other threads:[~2008-02-29 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 22:03 [PATCH] hda: incorrect DAC mixer on 92hd71bxxx Matthew Ranostay
2008-02-29 10:14 ` Takashi Iwai [this message]
2008-02-29 12:55 ` Matthew Ranostay
2008-02-29 13:22 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hmypkqdbz.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=Steven.Tellman@idt.com \
--cc=alsa-devel@alsa-project.org \
--cc=mranostay@embeddedalley.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox