* Re: Sound support for Neuros OSD2 Davinci based board. [not found] <4B0E7D5E.3080906@chelcom.ru> @ 2009-11-26 13:27 ` Chaithrika U S 2009-11-27 11:12 ` Mark Brown 2009-11-27 16:47 ` Mark Brown 1 sibling, 1 reply; 8+ messages in thread From: Chaithrika U S @ 2009-11-26 13:27 UTC (permalink / raw) To: 'A. Porodko', 'Liam Girdwood', 'Mark Brown', 'Jaroslav Kysela', 'Takashi Hello, On Thu, Nov 26, 2009 at 18:36:38, A. Porodko wrote: > Hello, > > Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. > Patch made against 2.6.32-rc6 kernel. > ------------------------------------------ > > -- > Best regards > Andrey A. Porodko > > > @@ -246,6 +249,9 @@ static int __init evm_init(void) if (machine_is_davinci_evm()) { evm_snd_dev_data = &evm_snd_devdata; index = 0; + } else if (machine_is_neuros_osd2()) { + evm_snd_dev_data = &evm_snd_devdata; + index = 0; The above can be combined with the check for DaVinci EVM if (machine_is_davinci_evm() || (machine_is_neuros_osd2()) { evm_snd_dev_data = &evm_snd_devdata; index = 0; Regards, Chaithrika ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. 2009-11-26 13:27 ` Sound support for Neuros OSD2 Davinci based board Chaithrika U S @ 2009-11-27 11:12 ` Mark Brown 2009-11-27 13:14 ` [alsa-devel] " A. Porodko 0 siblings, 1 reply; 8+ messages in thread From: Mark Brown @ 2009-11-27 11:12 UTC (permalink / raw) To: Chaithrika U S Cc: alsa-devel, 'David Brownell', 'Takashi Iwai', linux-kernel, 'Kevin Hilman', 'A. Porodko', 'Troy Kisky', 'Liam Girdwood' On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote: > @@ -246,6 +249,9 @@ static int __init evm_init(void) > if (machine_is_davinci_evm()) { > evm_snd_dev_data = &evm_snd_devdata; > index = 0; > + } else if (machine_is_neuros_osd2()) { > + evm_snd_dev_data = &evm_snd_devdata; > + index = 0; > The above can be combined with the check for DaVinci EVM > if (machine_is_davinci_evm() || > (machine_is_neuros_osd2()) { > evm_snd_dev_data = &evm_snd_devdata; > index = 0; I raised the same query when Andrey sent an off-list copy to me by mistake - he said that in future he intends to extend the driver to have additional features not present on the EVM (though for me that could always change the || later). Andrey, with Linux kernel patches reply to all is generally the way forward. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [alsa-devel] Sound support for Neuros OSD2 Davinci based board. 2009-11-27 11:12 ` Mark Brown @ 2009-11-27 13:14 ` A. Porodko 2009-11-27 13:28 ` Mark Brown 0 siblings, 1 reply; 8+ messages in thread From: A. Porodko @ 2009-11-27 13:14 UTC (permalink / raw) To: Mark Brown Cc: Chaithrika U S, 'Liam Girdwood', 'Jaroslav Kysela', 'Takashi Iwai', 'Troy Kisky', 'David Brownell', 'Kevin Hilman', alsa-devel, linux-kernel Mark Brown wrote: > On Thu, Nov 26, 2009 at 06:57:19PM +0530, Chaithrika U S wrote: > > >> @@ -246,6 +249,9 @@ static int __init evm_init(void) >> if (machine_is_davinci_evm()) { >> evm_snd_dev_data = &evm_snd_devdata; >> index = 0; >> + } else if (machine_is_neuros_osd2()) { >> + evm_snd_dev_data = &evm_snd_devdata; >> + index = 0; >> > > >> The above can be combined with the check for DaVinci EVM >> if (machine_is_davinci_evm() || >> (machine_is_neuros_osd2()) { >> evm_snd_dev_data = &evm_snd_devdata; >> index = 0; >> > > I raised the same query when Andrey sent an off-list copy to me by > mistake - he said that in future he intends to extend the driver to > have additional features not present on the EVM (though for me that > could always change the || later). > > Andrey, with Linux kernel patches reply to all is generally the way > forward. > Mark, Understood. Shall I change if if to if || then? -- Best regards Andrey A. Porodko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. 2009-11-27 13:14 ` [alsa-devel] " A. Porodko @ 2009-11-27 13:28 ` Mark Brown 0 siblings, 0 replies; 8+ messages in thread From: Mark Brown @ 2009-11-27 13:28 UTC (permalink / raw) To: A. Porodko Cc: alsa-devel, 'David Brownell', 'Takashi Iwai', linux-kernel, 'Troy Kisky', 'Kevin Hilman', Chaithrika U S, 'Liam Girdwood' On Fri, Nov 27, 2009 at 06:14:26PM +0500, A. Porodko wrote: > Mark Brown wrote: > > I raised the same query when Andrey sent an off-list copy to me by > > mistake - he said that in future he intends to extend the driver to > > have additional features not present on the EVM (though for me that > > could always change the || later). > Understood. Shall I change if if to if || then? Honestly I'm not that bothered, I was mostly following up to the list so that readers and the archives could see the answer to the query (I guessed you may have mistakenly replied off list). ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. [not found] <4B0E7D5E.3080906@chelcom.ru> 2009-11-26 13:27 ` Sound support for Neuros OSD2 Davinci based board Chaithrika U S @ 2009-11-27 16:47 ` Mark Brown 2009-11-28 15:07 ` Andrey A. Porodko 2009-11-30 6:47 ` Andrey A. Porodko 1 sibling, 2 replies; 8+ messages in thread From: Mark Brown @ 2009-11-27 16:47 UTC (permalink / raw) To: A. Porodko Cc: alsa-devel, David Brownell, Takashi Iwai, linux-kernel, Troy Kisky, Kevin Hilman, Chaithrika U S, Liam Girdwood On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote: > Hello, > > Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. > Patch made against 2.6.32-rc6 kernel. This doesn't apply against current ASoC. Could you please regenerate against this branch: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. 2009-11-27 16:47 ` Mark Brown @ 2009-11-28 15:07 ` Andrey A. Porodko 2009-11-30 6:47 ` Andrey A. Porodko 1 sibling, 0 replies; 8+ messages in thread From: Andrey A. Porodko @ 2009-11-28 15:07 UTC (permalink / raw) To: Mark Brown Cc: A. Porodko, Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Chaithrika U S, Troy Kisky, David Brownell, Kevin Hilman, alsa-devel, linux-kernel Mark Brown wrote: > On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote: > >> Hello, >> >> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. >> Patch made against 2.6.32-rc6 kernel. >> > > This doesn't apply against current ASoC. Could you please regenerate > against this branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 > > Mark Brown wrote: > On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote: > >> Hello, >> >> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. >> Patch made against 2.6.32-rc6 kernel. >> > > This doesn't apply against current ASoC. Could you please regenerate > against this branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 > > Hi, I wish I knew how to do this. I'm new with git and anly learn how to work with one tree. Complex operations confuse me a little. I generated something, but it doesn't look different from what I had before. P.S. Reading alsa-project wiki didn't shed more light. For my main tree is davinci tree and git is damn tricky. --------------------------- >From 699bbf676a3e74989063b398ff662fcf40469a16 Mon Sep 17 00:00:00 2001 From: Andrey Porodko <panda@chelcom.ru> Date: Mon, 23 Nov 2009 13:56:53 +0500 Subject: [PATCH] Davinci sound soc driver patch for Neuros OSD2 board support. Signed-off-by: Andrey Porodko <panda@chelcom.ru> --- sound/soc/davinci/davinci-evm.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c index 67414f6..ffdd30e 100644 --- a/sound/soc/davinci/davinci-evm.c +++ b/sound/soc/davinci/davinci-evm.c @@ -55,6 +55,9 @@ static int evm_hw_params(struct snd_pcm_substream *substream, else if (machine_is_davinci_evm()) sysclk = 12288000; + else if (machine_is_neuros_osd2()) + sysclk = 27000000; + else if (machine_is_davinci_da830_evm() || machine_is_davinci_da850_evm()) sysclk = 24576000; @@ -246,6 +249,9 @@ static int __init evm_init(void) if (machine_is_davinci_evm()) { evm_snd_dev_data = &evm_snd_devdata; index = 0; + } else if (machine_is_neuros_osd2()) { + evm_snd_dev_data = &evm_snd_devdata; + index = 0; } else if (machine_is_davinci_dm355_evm()) { evm_snd_dev_data = &evm_snd_devdata; index = 1; -- 1.5.6.5 ----------------------------------------- -- Best regards Andrey A. Porodko -- Best regards Andrey A. Porodko ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. 2009-11-27 16:47 ` Mark Brown 2009-11-28 15:07 ` Andrey A. Porodko @ 2009-11-30 6:47 ` Andrey A. Porodko 2009-11-30 6:52 ` Andrey A. Porodko 1 sibling, 1 reply; 8+ messages in thread From: Andrey A. Porodko @ 2009-11-30 6:47 UTC (permalink / raw) To: Mark Brown Cc: Jorge Luis Zapata Muga, Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Chaithrika U S, Troy Kisky, David Brownell, Kevin Hilman, alsa-devel, linux-kernel Mark Brown wrote: > On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote: > >> Hello, >> >> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. >> Patch made against 2.6.32-rc6 kernel. >> > > This doesn't apply against current ASoC. Could you please regenerate > against this branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 > > Hi Mark, Are you sure you have the latest davinci soc support in your tree? Mine file davinci_evm.c is 7.5k size, in your git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git repo your is 5.5k. Quick glance shows that in your repo davinci support lacks of da830_evm support. I'm confused which one is I have to use and apply patch to? -- Best regards Andrey A. Porodko ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: Sound support for Neuros OSD2 Davinci based board. 2009-11-30 6:47 ` Andrey A. Porodko @ 2009-11-30 6:52 ` Andrey A. Porodko 0 siblings, 0 replies; 8+ messages in thread From: Andrey A. Porodko @ 2009-11-30 6:52 UTC (permalink / raw) To: Andrey A. Porodko Cc: Mark Brown, Jorge Luis Zapata Muga, Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Chaithrika U S, Troy Kisky, David Brownell, Kevin Hilman, alsa-devel, linux-kernel Andrey A. Porodko wrote: Please, disregard my previous message. It's me stupid enough to forget to switch to the right branch. Sorry. > Mark Brown wrote: > >> On Thu, Nov 26, 2009 at 06:06:38PM +0500, A. Porodko wrote: >> >> >>> Hello, >>> >>> Here is a patch for Neuros OSD2 Davinci (DM6446) based board sound support. >>> Patch made against 2.6.32-rc6 kernel. >>> >>> >> This doesn't apply against current ASoC. Could you please regenerate >> against this branch: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git for-2.6.33 >> >> >> > Hi Mark, > > Are you sure you have the latest davinci soc support in your tree? > Mine file davinci_evm.c is 7.5k size, in your > > git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git > > repo your is 5.5k. Quick glance shows that in your repo davinci support > lacks of da830_evm support. > I'm confused which one is I have to use and apply patch to? > > -- Best regards Andrey A. Porodko ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2009-11-30 6:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4B0E7D5E.3080906@chelcom.ru>
2009-11-26 13:27 ` Sound support for Neuros OSD2 Davinci based board Chaithrika U S
2009-11-27 11:12 ` Mark Brown
2009-11-27 13:14 ` [alsa-devel] " A. Porodko
2009-11-27 13:28 ` Mark Brown
2009-11-27 16:47 ` Mark Brown
2009-11-28 15:07 ` Andrey A. Porodko
2009-11-30 6:47 ` Andrey A. Porodko
2009-11-30 6:52 ` Andrey A. Porodko
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox