Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: David Henningsson <david.henningsson@canonical.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] Show processing coefficients in codec proc file
Date: Thu, 19 Aug 2010 20:17:42 +0200	[thread overview]
Message-ID: <4C6D7546.4000506@canonical.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

This patch is helpful for tracking down bugs without having all
information about the chip.

-- 
David Henningsson, Canonical Ltd.
http://launchpad.net/~diwic

[-- Attachment #2: 0001-Show-processing-coefficients-in-codec-proc-file.patch --]
[-- Type: text/x-patch, Size: 1591 bytes --]

>From 568a3c0e45396cf6cfd8e8dac13f76f756c7e3f3 Mon Sep 17 00:00:00 2001
From: David Henningsson <david.henningsson@canonical.com>
Date: Thu, 19 Aug 2010 18:40:44 +0200
Subject: [PATCH 1/2] Show processing coefficients in codec proc file

Signed-off-by: David Henningsson <david.henningsson@canonical.com>
---
 sound/pci/hda/hda_proc.c |   16 ++++++++++++++--
 1 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/sound/pci/hda/hda_proc.c b/sound/pci/hda/hda_proc.c
index f025200..88e40f0 100644
--- a/sound/pci/hda/hda_proc.c
+++ b/sound/pci/hda/hda_proc.c
@@ -467,11 +467,23 @@ static void print_unsol_cap(struct snd_info_buffer *buffer,
 static void print_proc_caps(struct snd_info_buffer *buffer,
 			    struct hda_codec *codec, hda_nid_t nid)
 {
+        int i, val;
 	unsigned int proc_caps = snd_hda_param_read(codec, nid,
 						    AC_PAR_PROC_CAP);
+	unsigned int ncoeff = (proc_caps & AC_PCAP_NUM_COEF) >> 
+                              AC_PCAP_NUM_COEF_SHIFT;
+
 	snd_iprintf(buffer, "  Processing caps: benign=%d, ncoeff=%d\n",
-		    proc_caps & AC_PCAP_BENIGN,
-		    (proc_caps & AC_PCAP_NUM_COEF) >> AC_PCAP_NUM_COEF_SHIFT);
+		    proc_caps & AC_PCAP_BENIGN, ncoeff);
+	for (i = 0; i < ncoeff; i++) {
+		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_COEF_INDEX,
+				    i);
+		val = snd_hda_codec_read(codec, nid, 0,
+					 AC_VERB_GET_PROC_COEF, 0);
+                snd_iprintf(buffer, "  Processing coef %d: 0x%x\n", i, 
+                            val);
+        }
+        
 }
 
 static void print_conn_list(struct snd_info_buffer *buffer,
-- 
1.7.0.4


[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

             reply	other threads:[~2010-08-19 18:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-19 18:17 David Henningsson [this message]
2010-08-19 18:28 ` [PATCH] Show processing coefficients in codec proc file Takashi Iwai
2010-08-19 18:48   ` David Henningsson
2010-08-19 20:24     ` Takashi Iwai
2010-08-20 14:46       ` David Henningsson
2010-08-20 16:03         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6D7546.4000506@canonical.com \
    --to=david.henningsson@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox