* [PATCH] soundwire: amd: clear wake enable register for power off mode
@ 2024-11-12 18:51 Vijendar Mukunda
2024-11-26 1:26 ` Mukunda,Vijendar
2024-12-23 9:12 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Vijendar Mukunda @ 2024-11-12 18:51 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale, alsa-devel,
linux-kernel, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, mario.limonciello, Vijendar Mukunda
As per design for power off mode, clear the wake enable register during
resume sequence.
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
---
drivers/soundwire/amd_manager.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
index 5a4bfaef65fb..96a3aa6da711 100644
--- a/drivers/soundwire/amd_manager.c
+++ b/drivers/soundwire/amd_manager.c
@@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
return amd_sdw_clock_stop_exit(amd_manager);
} else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
+ writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
if (val) {
val |= AMD_SDW_CLK_RESUME_REQ;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: amd: clear wake enable register for power off mode
2024-11-12 18:51 [PATCH] soundwire: amd: clear wake enable register for power off mode Vijendar Mukunda
@ 2024-11-26 1:26 ` Mukunda,Vijendar
2024-12-23 9:12 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Mukunda,Vijendar @ 2024-11-26 1:26 UTC (permalink / raw)
To: vkoul
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale, alsa-devel,
linux-kernel, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, mario.limonciello
On 13/11/24 00:21, Vijendar Mukunda wrote:
> As per design for power off mode, clear the wake enable register during
> resume sequence.
Hi Vinod,
Could you please review the patch?
Thanks,
Vijendar
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> drivers/soundwire/amd_manager.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soundwire/amd_manager.c b/drivers/soundwire/amd_manager.c
> index 5a4bfaef65fb..96a3aa6da711 100644
> --- a/drivers/soundwire/amd_manager.c
> +++ b/drivers/soundwire/amd_manager.c
> @@ -1190,6 +1190,7 @@ static int __maybe_unused amd_resume_runtime(struct device *dev)
> if (amd_manager->power_mode_mask & AMD_SDW_CLK_STOP_MODE) {
> return amd_sdw_clock_stop_exit(amd_manager);
> } else if (amd_manager->power_mode_mask & AMD_SDW_POWER_OFF_MODE) {
> + writel(0x00, amd_manager->acp_mmio + ACP_SW_WAKE_EN(amd_manager->instance));
> val = readl(amd_manager->mmio + ACP_SW_CLK_RESUME_CTRL);
> if (val) {
> val |= AMD_SDW_CLK_RESUME_REQ;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soundwire: amd: clear wake enable register for power off mode
2024-11-12 18:51 [PATCH] soundwire: amd: clear wake enable register for power off mode Vijendar Mukunda
2024-11-26 1:26 ` Mukunda,Vijendar
@ 2024-12-23 9:12 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2024-12-23 9:12 UTC (permalink / raw)
To: Vijendar Mukunda
Cc: yung-chuan.liao, pierre-louis.bossart, sanyog.r.kale, alsa-devel,
linux-kernel, Basavaraj.Hiregoudar, Sunil-kumar.Dommati,
venkataprasad.potturu, mario.limonciello
On Wed, 13 Nov 2024 00:21:38 +0530, Vijendar Mukunda wrote:
> As per design for power off mode, clear the wake enable register during
> resume sequence.
>
>
Applied, thanks!
[1/1] soundwire: amd: clear wake enable register for power off mode
commit: 74148bb59e2064b87eb1715d9eb109adccb75316
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-23 9:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-12 18:51 [PATCH] soundwire: amd: clear wake enable register for power off mode Vijendar Mukunda
2024-11-26 1:26 ` Mukunda,Vijendar
2024-12-23 9:12 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox