From: Joonyoung Shim <dofmind@gmail.com>
To: broonie@opensource.wolfsonmicro.com
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] ASoC: Fix long name of control for dapm_switch
Date: Wed, 4 Mar 2009 10:47:09 +0900 [thread overview]
Message-ID: <4e1455be0903031747s65097766saea220037d1335ff@mail.gmail.com> (raw)
The length of long control name doesn't include the length of widget
name at present when widget->id is snd_soc_dapm_switch, so the long
control name of dapm_switch is shortened.
To avoid this problem, the long control name only for dapm_mixer_named_ctl
must have simply the kcontrol name.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
sound/soc/soc-dapm.c | 21 +++++++++------------
1 files changed, 9 insertions(+), 12 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 4b8dbbf..7a1fed1 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -331,26 +331,23 @@ static int dapm_new_mixer(struct snd_soc_codec *codec,
* for dapm_mixer_named_ctl this is simply the
* kcontrol name.
*/
- name_len = strlen(w->kcontrols[i].name) + 1;
- if (w->id == snd_soc_dapm_mixer)
- name_len += 1 + strlen(w->name);
+ if (w->id == snd_soc_dapm_mixer_named_ctl)
+ name_len = strlen(w->kcontrols[i].name) + 1;
+ else
+ name_len = 2 + strlen(w->name)
+ + strlen(w->kcontrols[i].name);
path->long_name = kmalloc(name_len, GFP_KERNEL);
if (path->long_name == NULL)
return -ENOMEM;
- switch (w->id) {
- case snd_soc_dapm_mixer:
- default:
- snprintf(path->long_name, name_len, "%s %s",
- w->name, w->kcontrols[i].name);
- break;
- case snd_soc_dapm_mixer_named_ctl:
+ if (w->id == snd_soc_dapm_mixer_named_ctl)
snprintf(path->long_name, name_len, "%s",
w->kcontrols[i].name);
- break;
- }
+ else
+ snprintf(path->long_name, name_len, "%s %s",
+ w->name, w->kcontrols[i].name);
path->long_name[name_len - 1] = '\0';
--
1.5.6.3
--
- Joonyoung Shim
next reply other threads:[~2009-03-04 1:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 1:47 Joonyoung Shim [this message]
2009-03-05 17:26 ` [PATCH] ASoC: Fix long name of control for dapm_switch Mark Brown
2009-03-06 0:02 ` Joonyoung Shim
2009-03-06 0:28 ` Joonyoung Shim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e1455be0903031747s65097766saea220037d1335ff@mail.gmail.com \
--to=dofmind@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox