From: Joonyoung Shim <dofmind@gmail.com>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix long name of control for dapm_switch
Date: Fri, 6 Mar 2009 09:28:06 +0900 [thread overview]
Message-ID: <4e1455be0903051628ifb0fe70w32d9babf13c7a43d@mail.gmail.com> (raw)
In-Reply-To: <4e1455be0903051602r198fd9a2gc5bde0ffd9ac8c0d@mail.gmail.com>
> ok, i will resend the patch.
>
>>
>>>
>>> - switch (w->id) {
>>> - case snd_soc_dapm_mixer:
>>> - default:
>>
>> Your chanegs here appear to only flip to an if/else from a switch
>> statement? Please mention things like this in your commit logs (or
>> split them into separate patches) - it makes your changes easier to
>> review.
>
> I think that a switch statement is used unnecessarily because this part has
> only to check whether w->id is named_ctl.
> ok, i will send them into splited patches.
> Thanks.
I found your commit at for-2.6.30 branch of your repository.
Thanks for your fixes.
--
- Joonyoung Shim
prev parent reply other threads:[~2009-03-06 0:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-04 1:47 [PATCH] ASoC: Fix long name of control for dapm_switch Joonyoung Shim
2009-03-05 17:26 ` Mark Brown
2009-03-06 0:02 ` Joonyoung Shim
2009-03-06 0:28 ` Joonyoung Shim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e1455be0903051628ifb0fe70w32d9babf13c7a43d@mail.gmail.com \
--to=dofmind@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox