* [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined [not found] <1351980150-24145-1-git-send-email-lee.jones@linaro.org> @ 2012-11-03 22:02 ` Lee Jones 2012-11-04 8:13 ` [alsa-devel] " Lars-Peter Clausen 0 siblings, 1 reply; 3+ messages in thread From: Lee Jones @ 2012-11-03 22:02 UTC (permalink / raw) To: linux-kernel; +Cc: alsa-devel, Mark Brown, Lee Jones If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support for the adav80x codec as it relies on a bus to operate. This patch fixes the build warnings below when SPI and I2C are not specified in the configuration. sound/soc/codecs/adav80x.c:842:22: warning: ‘adav80x_bus_probe’ defined but not used [-Wunused-function] sound/soc/codecs/adav80x.c:863:22: warning: ‘adav80x_bus_remove’ defined but not used [-Wunused-function] Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: alsa-devel@alsa-project.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index b92759a..0d8135a 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_AD1980 if SND_SOC_AC97_BUS select SND_SOC_AD73311 select SND_SOC_ADAU1373 if I2C - select SND_SOC_ADAV80X + select SND_SOC_ADAV80X if (I2C || I2C_MODULE || SPI_MASTER) select SND_SOC_ADS117X select SND_SOC_AK4104 if SPI_MASTER select SND_SOC_AK4535 if I2C -- 1.7.9.5 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined 2012-11-03 22:02 ` [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Lee Jones @ 2012-11-04 8:13 ` Lars-Peter Clausen 2012-11-04 10:31 ` Lee Jones 0 siblings, 1 reply; 3+ messages in thread From: Lars-Peter Clausen @ 2012-11-04 8:13 UTC (permalink / raw) To: Lee Jones; +Cc: linux-kernel, alsa-devel, Mark Brown On 11/03/2012 11:02 PM, Lee Jones wrote: > If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support > for the adav80x codec as it relies on a bus to operate. This patch > fixes the build warnings below when SPI and I2C are not specified in > the configuration. > > sound/soc/codecs/adav80x.c:842:22: warning: ‘adav80x_bus_probe’ defined but not used [-Wunused-function] > sound/soc/codecs/adav80x.c:863:22: warning: ‘adav80x_bus_remove’ defined but not used [-Wunused-function] > > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> > Cc: alsa-devel@alsa-project.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> > --- > sound/soc/codecs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > index b92759a..0d8135a 100644 > --- a/sound/soc/codecs/Kconfig > +++ b/sound/soc/codecs/Kconfig > @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS > select SND_SOC_AD1980 if SND_SOC_AC97_BUS > select SND_SOC_AD73311 > select SND_SOC_ADAU1373 if I2C > - select SND_SOC_ADAV80X > + select SND_SOC_ADAV80X if (I2C || I2C_MODULE || SPI_MASTER) That should be 'if SND_SOC_I2C_AND_SPI', but otherwise agreed. > select SND_SOC_ADS117X > select SND_SOC_AK4104 if SPI_MASTER > select SND_SOC_AK4535 if I2C ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined 2012-11-04 8:13 ` [alsa-devel] " Lars-Peter Clausen @ 2012-11-04 10:31 ` Lee Jones 0 siblings, 0 replies; 3+ messages in thread From: Lee Jones @ 2012-11-04 10:31 UTC (permalink / raw) To: Lars-Peter Clausen; +Cc: linux-kernel, alsa-devel, Mark Brown Thanks for reviewing Lars. Here's the result: commit c4f60d00d04abfb730a54a97204873dafc6473ae Author: Lee Jones <lee.jones@linaro.org> Date: Sat Nov 3 22:54:23 2012 +0100 ASoC: Only compile adav80x codec when a bus is defined If !CONFIG_SPI and !CONFIG_I2C* then there is no point adding support for the adav80x codec as it relies on a bus to operate. This patch fixes the build warnings below when SPI and I2C are not specified in the configuration. sound/soc/codecs/adav80x.c:842:22: warning: ‘adav80x_bus_probe’ defined but not used [-Wunused-function] sound/soc/codecs/adav80x.c:863:22: warning: ‘adav80x_bus_remove’ defined but not used [-Wunused-function] Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> Cc: alsa-devel@alsa-project.org Signed-off-by: Lee Jones <lee.jones@linaro.org> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index b92759a..3ae3a4b 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -19,7 +19,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_AD1980 if SND_SOC_AC97_BUS select SND_SOC_AD73311 select SND_SOC_ADAU1373 if I2C - select SND_SOC_ADAV80X + select SND_SOC_ADAV80X if SND_SOC_I2C_AND_SPI select SND_SOC_ADS117X select SND_SOC_AK4104 if SPI_MASTER select SND_SOC_AK4535 if I2C ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-04 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1351980150-24145-1-git-send-email-lee.jones@linaro.org>
2012-11-03 22:02 ` [PATCH 5/9] ASoC: Only compile adav80x codec when a bus is defined Lee Jones
2012-11-04 8:13 ` [alsa-devel] " Lars-Peter Clausen
2012-11-04 10:31 ` Lee Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox