[PATCH] ASoC: dapm: Use card_list during DAPM shutdown

[PATCH] ASoC: dapm: Use card_list during DAPM shutdown

[Misael Lopez Cruz]

DAPM shutdown incorrectly uses "list" field of codec struct while
iterating over probed components (codec_dev_list). "list" field
refers to codecs registered in the system, "card_list" field is
used for probed components.

Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>
---
 sound/soc/soc-dapm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index d0a4be3..6e35bca 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3745,7 +3745,7 @@ void snd_soc_dapm_shutdown(struct snd_soc_card *card)
 {
 	struct snd_soc_codec *codec;
 
-	list_for_each_entry(codec, &card->codec_dev_list, list) {
+	list_for_each_entry(codec, &card->codec_dev_list, card_list) {
 		soc_dapm_shutdown_codec(&codec->dapm);
 		if (codec->dapm.bias_level == SND_SOC_BIAS_STANDBY)
 			snd_soc_dapm_set_bias_level(&codec->dapm,
-- 
1.7.4.1

Re: [PATCH] ASoC: dapm: Use card_list during DAPM shutdown

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

On Thu, Nov 08, 2012 at 12:03:12PM -0600, Misael Lopez Cruz wrote:
> DAPM shutdown incorrectly uses "list" field of codec struct while
> iterating over probed components (codec_dev_list). "list" field
> refers to codecs registered in the system, "card_list" field is
> used for probed components.

> Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
> Signed-off-by: Liam Girdwood <lrg@ti.com>

Applied, with Liam's signoff changed to an ack - please don't add
signoffs for other people, the signoff means something fairly specific.
Please see SubmittingPatches for details.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH] ASoC: dapm: Use card_list during DAPM shutdown

[Liam Girdwood]

On 09/11/12 16:02, Mark Brown wrote:
> On Thu, Nov 08, 2012 at 12:03:12PM -0600, Misael Lopez Cruz wrote:
>> DAPM shutdown incorrectly uses "list" field of codec struct while
>> iterating over probed components (codec_dev_list). "list" field
>> refers to codecs registered in the system, "card_list" field is
>> used for probed components.
>
>> Signed-off-by: Misael Lopez Cruz <misael.lopez@ti.com>
>> Signed-off-by: Liam Girdwood <lrg@ti.com>
>
> Applied, with Liam's signoff changed to an ack - please don't add
> signoffs for other people, the signoff means something fairly specific.
> Please see SubmittingPatches for details.
>

Fwiw, We both worked on this hence the dual sign-off, I would have complained 
anyway if my ack/sob had been added by mistake.

Liam

Re: [PATCH] ASoC: dapm: Use card_list during DAPM shutdown

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 317 bytes --]

On Fri, Nov 09, 2012 at 04:17:08PM +0000, Liam Girdwood wrote:

> Fwiw, We both worked on this hence the dual sign-off, I would have
> complained anyway if my ack/sob had been added by mistake.

Ah, OK - normally for that the Signoffs will be the other way around
(the person sending the mail last).  I'll change it.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]