From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, lars@metafoo.de,
matt@genesi-usa.com, eric.nelson@boundarydevices.com,
broonie@kernel.org
Subject: Re: [PATCH v5 2/2] ASoC: sgtl5000: Fix driver probe after reset
Date: Fri, 10 May 2013 13:13:52 -0700 [thread overview]
Message-ID: <518D5500.4050101@boundarydevices.com> (raw)
In-Reply-To: <CAOMZO5Dj83WqD2tQBQDBz9FzvLQGyuv-4yvb4gwL=rRq6DxPuw@mail.gmail.com>
On 5/10/2013 12:18 PM, Fabio Estevam wrote:
> On Fri, May 10, 2013 at 4:16 PM, Troy Kisky
> <troy.kisky@boundarydevices.com> wrote:
>
>> Since Sabrelite uses "dummy" regulators (always on), have you tested with a
>> boards that
>> actually uses regulators?
> I don't have any board that drives the sgtl5000 power supplies from a
> PMIC, for example.
>
>> I would think that some regulators would need to be on before you could even
>> read
>> the ID register.
> Sure. That's why I placed the ID reading after turning on the regulators :-)
>
Hmm. Maybe I need some remedial classes. This is what the flow looks
like to me.
sgtl5000_i2c_probe
regmap_read(sgtl5000->regmap, SGTL5000_CHIP_ID, ®);
snd_soc_register_codec(&client->dev,&sgtl5000_driver, &sgtl5000_dai, 1);
sgtl5000_probe
sgtl5000_enable_regulators
next prev parent reply other threads:[~2013-05-10 20:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-10 0:15 [PATCH v5 1/2] ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe() Fabio Estevam
2013-05-10 0:15 ` [PATCH v5 2/2] ASoC: sgtl5000: Fix driver probe after reset Fabio Estevam
2013-05-10 1:17 ` Troy Kisky
2013-05-10 2:12 ` Fabio Estevam
[not found] ` <CAKGA1bnhE3dZe8P+aJm+cps+Rp4abSGOMmPckGw_0fCnh9e6+A@mail.gmail.com>
2013-05-10 17:31 ` Fabio Estevam
2013-05-10 19:11 ` Troy Kisky
2013-05-10 19:16 ` Troy Kisky
2013-05-10 19:18 ` Fabio Estevam
2013-05-10 19:39 ` Fabio Estevam
2013-05-10 20:56 ` Mark Brown
2013-05-10 20:58 ` Mark Brown
2013-05-10 20:13 ` Troy Kisky [this message]
2013-05-10 19:23 ` Fabio Estevam
2013-05-10 9:16 ` Mark Brown
2013-05-10 16:38 ` Eric Nelson
2013-05-10 20:59 ` Mark Brown
2013-05-10 9:15 ` [PATCH v5 1/2] ASoC: sgtl5000: Read SGTL5000_CHIP_ID in i2c_probe() Mark Brown
2013-05-10 16:37 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518D5500.4050101@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eric.nelson@boundarydevices.com \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lars@metafoo.de \
--cc=matt@genesi-usa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox