* Re: [Alsa-devel] add support for syba 7.1 surround sound card
[not found] <51804394.a36cec0a.2c7d.291b@mx.google.com>
@ 2013-05-21 8:50 ` Clemens Ladisch
0 siblings, 0 replies; only message in thread
From: Clemens Ladisch @ 2013-05-21 8:50 UTC (permalink / raw)
To: good1.2guy; +Cc: alsa-devel, linux-kernel
good1.2guy@gmail.com wrote:
> Summary: add support for syba 7.1 surround sound card
> Keywords: syba via VT1723 Tremor
> Kernel: 3.8.8-203.fc18.x86_64
What are these three lines for?
> add support for syba 7.1 surround sound card
> actually the card only has 6 dmas, so it is really only 5.1
The website shows a daughterboard.
> added code to force_rate setting to not fail EBUSY when the dmas are running.
> suggest using force_rate with pulseaudio to avoid loops with error logging.
This sounds as if it has nothing to do with this particular SYBA card
but affects all VT1723 cards. Please move it into a separate patch.
And there should be no reason for a module parameter; if this is a bug
in the driver and/or in PulseAudio, it should be just fixed.
> Signed-off-by: psmith2004@yahoo.com
Real names only.
Please read Documentation/SubmittingPatches.
> +static void syba_quirk_open(struct snd_ice1712 *ice)
> +{
> + unsigned long flags;
It's common to have an empty line here.
> + spin_lock_irqsave(&ice->reg_lock, flags);
> + outb(0xff, ICEREG1724(ice, AC97_CFG));
> + udelay(500);
> + outb(ice->eeprom.data[ICE_EEP2_ACLINK], ICEREG1724(ice, AC97_CFG));
> + spin_unlock_irqrestore(&ice->reg_lock, flags);
> +}
What is the reason for this quirk?
Is it possible that this might be needed for other cards using a AC'97
codec?
Regards,
Clemens
^ permalink raw reply [flat|nested] only message in thread