From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, vkoul@kernel.org
Subject: Re: [PATCH v2 2/9] ASoC: q6asm: make commands specific to streams
Date: Tue, 21 Jul 2020 14:31:56 -0500 [thread overview]
Message-ID: <52075b51-2053-573a-4cd0-685d3d469bdf@linux.intel.com> (raw)
In-Reply-To: <20200721165306.29082-3-srinivas.kandagatla@linaro.org>
> diff --git a/sound/soc/qcom/qdsp6/q6asm-dai.c b/sound/soc/qcom/qdsp6/q6asm-dai.c
> index 941f3216399c..fb0488e7beb9 100644
> --- a/sound/soc/qcom/qdsp6/q6asm-dai.c
> +++ b/sound/soc/qcom/qdsp6/q6asm-dai.c
> @@ -67,6 +67,8 @@ struct q6asm_dai_rtd {
> uint16_t bits_per_sample;
> uint16_t source; /* Encoding source bit mask */
> struct audio_client *audio_client;
> + /* Active */
nit-pick: what does this 'Active' comment try to say? the stream_id
seems to be used for RUN/EOS/CLOSE operations.
> + uint32_t stream_id;
> uint16_t session_id;
> enum stream_state state;
> };
> @@ -184,8 +186,8 @@ static void event_handler(uint32_t opcode, uint32_t token,
> switch (opcode) {
> case ASM_CLIENT_EVENT_CMD_RUN_DONE:
> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
> - q6asm_write_async(prtd->audio_client,
> - prtd->pcm_count, 0, 0, NO_TIMESTAMP);
> + q6asm_write_async(prtd->audio_client, prtd->stream_id,
> + prtd->pcm_count, 0, 0, 0);
In the V1 review we discussed this
"
> sound/soc/qcom/qdsp6/q6asm.h:#define NO_TIMESTAMP 0xFF00
>
> is the change on the previous line intentional?
May be not!
Plan is that the users of these apis will send flags directly instead of
boiler plating this!
This change should go as part of next patch("[PATCH 04/11] ASoC: q6asm:
use flags directly from asm-dai") which would make it much clear!
"
doesn't look like there was a change here?
next prev parent reply other threads:[~2020-07-21 23:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:52 [PATCH v2 0/9] ASoC: qdsp6: add gapless compressed audio support Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 1/9] ASoC: q6asm: rename misleading session id variable Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 2/9] ASoC: q6asm: make commands specific to streams Srinivas Kandagatla
2020-07-21 19:31 ` Pierre-Louis Bossart [this message]
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 3/9] ASoC: q6asm: use flags directly from q6asm-dai Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 4/9] ASoC: q6asm: add length to write command token Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 5/9] ASoC: q6asm: add support to remove intial and trailing silence Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 6/9] ASoC: q6asm: add support to gapless flag in q6asm open Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 7/9] ASoC: q6asm-dai: add next track metadata support Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support Srinivas Kandagatla
2020-07-21 19:53 ` Pierre-Louis Bossart
2020-07-22 9:00 ` Srinivas Kandagatla
2020-07-22 15:31 ` Pierre-Louis Bossart
2020-07-21 16:53 ` [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback Srinivas Kandagatla
2020-07-21 19:54 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52075b51-2053-573a-4cd0-685d3d469bdf@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox