From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, ckeepax@opensource.cirrus.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com, vkoul@kernel.org
Subject: Re: [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback
Date: Tue, 21 Jul 2020 14:54:41 -0500 [thread overview]
Message-ID: <e3ad122c-d560-33f6-1bff-ea2b16fe47b5@linux.intel.com> (raw)
In-Reply-To: <20200721165306.29082-10-srinivas.kandagatla@linaro.org>
> +static int q6asm_compr_copy(struct snd_soc_component *component,
> + struct snd_compr_stream *stream, char __user *buf,
> + size_t count)
> {
> struct snd_compr_runtime *runtime = stream->runtime;
> struct q6asm_dai_rtd *prtd = runtime->private_data;
> unsigned long flags;
> + u32 wflags = 0;
> + int avail, bytes_in_flight = 0;
> + void *dstn;
> + size_t copy;
> + u32 app_pointer;
> + u32 bytes_received;
> +
> + bytes_received = prtd->bytes_received;
> +
> + /**
/*
> + * Make sure that next track data pointer is aligned at 32 bit boundary
> + * This is a Mandatory requirement from DSP data buffers alignment
> + */
> + if (prtd->next_track)
> + bytes_received = ALIGN(prtd->bytes_received, prtd->pcm_count);
> +
> + app_pointer = bytes_received/prtd->pcm_size;
> + app_pointer = bytes_received - (app_pointer * prtd->pcm_size);
> + dstn = prtd->dma_buffer.area + app_pointer;
> +
> + if (count < prtd->pcm_size - app_pointer) {
> + if (copy_from_user(dstn, buf, count))
> + return -EFAULT;
> + } else {
> + copy = prtd->pcm_size - app_pointer;
> + if (copy_from_user(dstn, buf, copy))
> + return -EFAULT;
> + if (copy_from_user(prtd->dma_buffer.area, buf + copy,
> + count - copy))
> + return -EFAULT;
> + }
prev parent reply other threads:[~2020-07-21 23:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:52 [PATCH v2 0/9] ASoC: qdsp6: add gapless compressed audio support Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 1/9] ASoC: q6asm: rename misleading session id variable Srinivas Kandagatla
2020-07-21 16:52 ` [PATCH v2 2/9] ASoC: q6asm: make commands specific to streams Srinivas Kandagatla
2020-07-21 19:31 ` Pierre-Louis Bossart
2020-07-22 8:59 ` Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 3/9] ASoC: q6asm: use flags directly from q6asm-dai Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 4/9] ASoC: q6asm: add length to write command token Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 5/9] ASoC: q6asm: add support to remove intial and trailing silence Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 6/9] ASoC: q6asm: add support to gapless flag in q6asm open Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 7/9] ASoC: q6asm-dai: add next track metadata support Srinivas Kandagatla
2020-07-21 16:53 ` [PATCH v2 8/9] ASoC: qdsp6-dai: add gapless support Srinivas Kandagatla
2020-07-21 19:53 ` Pierre-Louis Bossart
2020-07-22 9:00 ` Srinivas Kandagatla
2020-07-22 15:31 ` Pierre-Louis Bossart
2020-07-21 16:53 ` [PATCH v2 9/9] ASoC: q6asm-dai: add support to copy callback Srinivas Kandagatla
2020-07-21 19:54 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ad122c-d560-33f6-1bff-ea2b16fe47b5@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox