From: Daniel Mack <zonque@gmail.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization
Date: Tue, 04 Mar 2014 12:48:19 +0100 [thread overview]
Message-ID: <5315BD83.2090504@gmail.com> (raw)
In-Reply-To: <1393921177-24294-1-git-send-email-lars@metafoo.de>
On 03/04/2014 09:19 AM, Lars-Peter Clausen wrote:
> The driver uses automatic IO setup, which will also initialize the control_data
> field of the CODEC, no need to do it manually.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Daniel Mack <daniel@zonque.org>
Thanks!
Daniel
> ---
> sound/soc/codecs/ak4104.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c
> index b4819dc..10adf25 100644
> --- a/sound/soc/codecs/ak4104.c
> +++ b/sound/soc/codecs/ak4104.c
> @@ -174,8 +174,6 @@ static int ak4104_probe(struct snd_soc_codec *codec)
> struct ak4104_private *ak4104 = snd_soc_codec_get_drvdata(codec);
> int ret;
>
> - codec->control_data = ak4104->regmap;
> -
> /* set power-up and non-reset bits */
> ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1,
> AK4104_CONTROL1_PW | AK4104_CONTROL1_RSTN,
>
next prev parent reply other threads:[~2014-03-04 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:19 [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization Lars-Peter Clausen
2014-03-04 11:48 ` Daniel Mack [this message]
2014-03-05 1:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315BD83.2090504@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox