* [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization
@ 2014-03-04 8:19 Lars-Peter Clausen
2014-03-04 11:48 ` Daniel Mack
2014-03-05 1:25 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2014-03-04 8:19 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, Lars-Peter Clausen, Daniel Mack
The driver uses automatic IO setup, which will also initialize the control_data
field of the CODEC, no need to do it manually.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/ak4104.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c
index b4819dc..10adf25 100644
--- a/sound/soc/codecs/ak4104.c
+++ b/sound/soc/codecs/ak4104.c
@@ -174,8 +174,6 @@ static int ak4104_probe(struct snd_soc_codec *codec)
struct ak4104_private *ak4104 = snd_soc_codec_get_drvdata(codec);
int ret;
- codec->control_data = ak4104->regmap;
-
/* set power-up and non-reset bits */
ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1,
AK4104_CONTROL1_PW | AK4104_CONTROL1_RSTN,
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization
2014-03-04 8:19 [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization Lars-Peter Clausen
@ 2014-03-04 11:48 ` Daniel Mack
2014-03-05 1:25 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Mack @ 2014-03-04 11:48 UTC (permalink / raw)
To: Lars-Peter Clausen, Mark Brown, Liam Girdwood; +Cc: alsa-devel
On 03/04/2014 09:19 AM, Lars-Peter Clausen wrote:
> The driver uses automatic IO setup, which will also initialize the control_data
> field of the CODEC, no need to do it manually.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Daniel Mack <daniel@zonque.org>
Thanks!
Daniel
> ---
> sound/soc/codecs/ak4104.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/codecs/ak4104.c b/sound/soc/codecs/ak4104.c
> index b4819dc..10adf25 100644
> --- a/sound/soc/codecs/ak4104.c
> +++ b/sound/soc/codecs/ak4104.c
> @@ -174,8 +174,6 @@ static int ak4104_probe(struct snd_soc_codec *codec)
> struct ak4104_private *ak4104 = snd_soc_codec_get_drvdata(codec);
> int ret;
>
> - codec->control_data = ak4104->regmap;
> -
> /* set power-up and non-reset bits */
> ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1,
> AK4104_CONTROL1_PW | AK4104_CONTROL1_RSTN,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization
2014-03-04 8:19 [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization Lars-Peter Clausen
2014-03-04 11:48 ` Daniel Mack
@ 2014-03-05 1:25 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-03-05 1:25 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: alsa-devel, Liam Girdwood, Daniel Mack
[-- Attachment #1.1: Type: text/plain, Size: 217 bytes --]
On Tue, Mar 04, 2014 at 09:19:37AM +0100, Lars-Peter Clausen wrote:
> The driver uses automatic IO setup, which will also initialize the control_data
> field of the CODEC, no need to do it manually.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-05 1:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-04 8:19 [PATCH] ASoC: ak4104: Remove superfluous codec->control_data initialization Lars-Peter Clausen
2014-03-04 11:48 ` Daniel Mack
2014-03-05 1:25 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox