Re: [PATCH] ak4642: show error if register write fails

[Ben Dooks <ben.dooks@codethink.co.uk>]

On 11/03/14 13:59, Lars-Peter Clausen wrote:
> On 03/11/2014 12:21 PM, Mark Brown wrote:
>> On Tue, Mar 11, 2014 at 11:18:30AM +0000, Ben Dooks wrote:
>>> On 10/03/14 23:40, Mark Brown wrote:
>>
>>>> Two things here.  One is that this should be a dev_err() and the other
>>>> is that if this is worth doing shouldn't it just be in the core - I see
>>>> nothing driver specific here?
>>
>>> Sorry, didn't see a device in "struct snd_soc_codec *codec" so I went
>>> for a printk (although it was pr_info instead of pr_err).
>>
>> codec->dev.
>>
>>> If you think that changing the two snd_soc calls to print errors
>>> when anything bad happens then that would also be a good idea then
>>> I can send a patch for that.
>>
>> That would be better, yes.
>
> In my opinion it's better to pass the error on to the upper levels. E.g.
> if userspace opens the PCM device and there is an IO error in the
> startup callback then that error should be passed on to the userspace
> application rather than doing a out of band error reporting and adding a
> entry to the kernel log.

 From a grep, there doesn't seem to be much in the way of error
checking in a number of the codec drivers.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius