public inbox for alsa-devel@alsa-project.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: mick <mick37@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: Tenor TE8802, USB : clics and crackles during music play
Date: Tue, 08 Apr 2014 12:29:47 +0200	[thread overview]
Message-ID: <5343CF9B.8020202@ladisch.de> (raw)
In-Reply-To: <op.xdznse1cwx6sbz@ws00534.pq>

mick wrote:
> are you asking me personally to test or is this a general call for the
> group?

Both.  I cannot apply this patch before it is tested by somebody.

> If you need me to test, what version of kernel sources do I patch?

Any more-or-less recent version should work.

> Your patch looks quite different from the solution I pointed out. Why?

That patch did some inefficient and superfluous things, and anonymous
patches cannot go into the kernel.

> In particular the assertion:
>> +         * The TEAC UD-H01 firmware sometimes changes the feedback value
>> +         * by +/- 0x1.0000.
> is quite different from the assertion
> "the 3rd byte of the feadback value is getting corrupted and probably
> changing when it should not "

These two assertions describe the same change.

> Also, you made it quite explicit for the TEAC UD-H01 but I think it
> should be more general. I have the Teac A-H01 and it also has the
> problem. As far as I gather from the various discussions on the Web it
> probably is a general Tenor 8802 issue.

I was not aware of these other devices.  What are the vendor/device IDs
of the A-H01?


Regards,
Clemens

  reply	other threads:[~2014-04-08 10:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-12 15:36 Tenor TE8802, USB : clics and crackles during music play Eric F
2014-01-12 15:43 ` Eric F
2014-01-13  7:05   ` Eric F
2014-01-13  7:09     ` Eric F
2014-01-14 14:34   ` Daniel Mack
2014-04-04 15:01     ` Mick
2014-04-04 15:26       ` Clemens Ladisch
2014-04-07 14:43         ` mick
     [not found]           ` <534305F1.8040805@ladisch.de>
2014-04-08  8:13             ` mick
2014-04-08 10:29               ` Clemens Ladisch [this message]
     [not found]                 ` <op.xd3dibs3wx6sbz@ws00534.pq>
2014-04-10  9:23                   ` Clemens Ladisch
2014-04-14 10:44                     ` mick
2014-04-17  7:27                       ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5343CF9B.8020202@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=mick37@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox