From: Daniel Mack <daniel@zonque.org>
To: mick <mick37@gmx.de>, Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org, Andrea Messa <andr.messa@tiscali.it>
Subject: Re: Tenor TE8802, USB : clics and crackles during music play
Date: Thu, 17 Apr 2014 09:27:37 +0200 [thread overview]
Message-ID: <534F8269.6000005@zonque.org> (raw)
In-Reply-To: <op.xeaysqhpwx6sbz@ws00534.pq>
On 04/14/2014 12:44 PM, mick wrote:
> I figured out what the problem is.
> When I said the quirk code gets called I made a mistake. It did not.
> What happens is this:
> You are setting udh01_fb_quirk in the sync endpoint but at the line where
> you query it you are asking the data endpoint. So the patch of the patch
> is:
>
> - if (unlikely(ep->udh01_fb_quirk)) {
> + if (unlikely(sender->udh01_fb_quirk)) {
>
> With this change everything works fine with my TEAC A-H01.
> The crackle is gone and grep for the momentary frequency shows no jumps
> anymore.
Nice catch. Clemens, with the above correction of the patch, Andrea
Messa reported success as well (had some private conversation on this).
When respinning the patch, you can add
Tested-by: Andrea Messa <andr.messa@tiscali.it>
Many thanks, everyone!
Daniel
prev parent reply other threads:[~2014-04-17 7:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 15:36 Tenor TE8802, USB : clics and crackles during music play Eric F
2014-01-12 15:43 ` Eric F
2014-01-13 7:05 ` Eric F
2014-01-13 7:09 ` Eric F
2014-01-14 14:34 ` Daniel Mack
2014-04-04 15:01 ` Mick
2014-04-04 15:26 ` Clemens Ladisch
2014-04-07 14:43 ` mick
[not found] ` <534305F1.8040805@ladisch.de>
2014-04-08 8:13 ` mick
2014-04-08 10:29 ` Clemens Ladisch
[not found] ` <op.xd3dibs3wx6sbz@ws00534.pq>
2014-04-10 9:23 ` Clemens Ladisch
2014-04-14 10:44 ` mick
2014-04-17 7:27 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534F8269.6000005@zonque.org \
--to=daniel@zonque.org \
--cc=alsa-devel@alsa-project.org \
--cc=andr.messa@tiscali.it \
--cc=clemens@ladisch.de \
--cc=mick37@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox