From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexander Stein <alexanders83@web.de>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data
Date: Wed, 16 Apr 2014 09:39:25 +0200 [thread overview]
Message-ID: <534E33AD.8060403@atmel.com> (raw)
In-Reply-To: <1397583537-4222-2-git-send-email-alexanders83@web.de>
On 15/04/2014 19:38, Alexander Stein :
> This platform data member is unused, so remove it.
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> include/sound/atmel-ac97c.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/sound/atmel-ac97c.h b/include/sound/atmel-ac97c.h
> index e6aabdb..00e6c289 100644
> --- a/include/sound/atmel-ac97c.h
> +++ b/include/sound/atmel-ac97c.h
> @@ -23,7 +23,6 @@
> * @reset_pin: GPIO pin wired to the reset input on the external AC97 codec,
> * optional to use, set to -ENODEV if not in use. AC97 layer will
> * try to do a software reset of the external codec anyway.
> - * @flags: Flags for which directions should be enabled.
> *
> * If the user do not want to use a DMA channel for playback or capture, i.e.
> * only one feature is required on the board. The slave for playback or capture
> @@ -33,7 +32,6 @@
> struct ac97c_platform_data {
> struct dw_dma_slave rx_dws;
> struct dw_dma_slave tx_dws;
> - unsigned int flags;
> int reset_pin;
> };
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-04-16 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397293707-26890-1-git-send-email-alexanders83@web.de>
2014-04-15 17:38 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-15 17:38 ` [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-16 7:39 ` Nicolas Ferre [this message]
2014-04-16 7:39 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Nicolas Ferre
2014-04-16 8:23 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E33AD.8060403@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexanders83@web.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox