From: Takashi Iwai <tiwai@suse.de>
To: Alexander Stein <alexanders83@web.de>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver
Date: Wed, 16 Apr 2014 10:23:24 +0200 [thread overview]
Message-ID: <s5h4n1tsmwz.wl%tiwai@suse.de> (raw)
In-Reply-To: <1397583537-4222-1-git-send-email-alexanders83@web.de>
At Tue, 15 Apr 2014 19:38:56 +0200,
Alexander Stein wrote:
>
> This reduces some boilerplate code.
>
> Signed-off-by: Alexander Stein <alexanders83@web.de>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Thanks, applied these two cleanup patches now.
Takashi
> ---
> sound/atmel/ac97c.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index 05ec049..a04d2317 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -1198,6 +1198,7 @@ static int atmel_ac97c_remove(struct platform_device *pdev)
> }
>
> static struct platform_driver atmel_ac97c_driver = {
> + .probe = atmel_ac97c_probe,
> .remove = atmel_ac97c_remove,
> .driver = {
> .name = "atmel_ac97c",
> @@ -1205,19 +1206,7 @@ static struct platform_driver atmel_ac97c_driver = {
> .pm = ATMEL_AC97C_PM_OPS,
> },
> };
> -
> -static int __init atmel_ac97c_init(void)
> -{
> - return platform_driver_probe(&atmel_ac97c_driver,
> - atmel_ac97c_probe);
> -}
> -module_init(atmel_ac97c_init);
> -
> -static void __exit atmel_ac97c_exit(void)
> -{
> - platform_driver_unregister(&atmel_ac97c_driver);
> -}
> -module_exit(atmel_ac97c_exit);
> +module_platform_driver(atmel_ac97c_driver);
>
> MODULE_LICENSE("GPL");
> MODULE_DESCRIPTION("Driver for Atmel AC97 controller");
> --
> 1.9.2
>
prev parent reply other threads:[~2014-04-16 8:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397293707-26890-1-git-send-email-alexanders83@web.de>
2014-04-15 17:38 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Alexander Stein
2014-04-15 17:38 ` [PATCH v2 2/2] ALSA: sound/atmel-ac97c.h: Remove unused flags from platform data Alexander Stein
2014-04-16 7:39 ` Nicolas Ferre
2014-04-16 7:39 ` [PATCH v2 1/2] ALSA: sound/atmel/ac97c.c: Convert to module_platform_driver Nicolas Ferre
2014-04-16 8:23 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h4n1tsmwz.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alexanders83@web.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox