From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, lars@metafoo.de,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 0/2] ASoC: tlv320aic3x: Fix snd_soc_dapm_put_volsw_aic3x callback
Date: Tue, 27 May 2014 16:04:38 +0300 [thread overview]
Message-ID: <53848D66.1050204@ti.com> (raw)
In-Reply-To: <20140527110259.GM12304@sirena.org.uk>
Mark,
On 05/27/2014 02:02 PM, Mark Brown wrote:
> On Tue, May 27, 2014 at 01:53:04PM +0300, Peter Ujfalusi wrote:
>> Hi,
>>
>> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to
>> control" changed the way how the 'value' has been stored for a widget.
>> This resulted issues with codec drivers needing and using custom dapm put
>> callbacks to handle the hw underneath, like the tlv320aic3x driver.
>> Since the driver is not updated following the mentioned commit it is mostly
>> broken when we try to change Left/Righ PGA mixers:
>
> Applied both, thanks.
After discussing this with Lars over the IRC, would it be possible to drop
these patches? I'll come back with another set to fix this issue tomorrow.
Thanks,
Péter
next prev parent reply other threads:[~2014-05-27 13:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 10:53 [PATCH 0/2] ASoC: tlv320aic3x: Fix snd_soc_dapm_put_volsw_aic3x callback Peter Ujfalusi
2014-05-27 10:53 ` [PATCH 1/2] ASoC: dapm: Export dapm_kcontrol_set_value() so it can be used by drivers Peter Ujfalusi
2014-05-27 10:53 ` [PATCH 2/2] ASoC: tlv320aic3x: Fix Left/Rigth PGA mixer widgets/kcontrols Peter Ujfalusi
2014-05-27 11:18 ` Lars-Peter Clausen
2014-05-27 11:41 ` Peter Ujfalusi
2014-05-27 11:54 ` Lars-Peter Clausen
2014-05-27 12:09 ` Lars-Peter Clausen
2014-05-27 12:19 ` Peter Ujfalusi
2014-05-27 12:24 ` Lars-Peter Clausen
2014-05-27 11:02 ` [PATCH 0/2] ASoC: tlv320aic3x: Fix snd_soc_dapm_put_volsw_aic3x callback Mark Brown
2014-05-27 13:04 ` Peter Ujfalusi [this message]
2014-05-28 7:27 ` Lars-Peter Clausen
2014-05-28 13:12 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53848D66.1050204@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox