Re: [PATCH 0/2] ASoC: tlv320aic3x: Fix snd_soc_dapm_put_volsw_aic3x callback

[Peter Ujfalusi <peter.ujfalusi@ti.com>]

On 05/28/2014 10:27 AM, Lars-Peter Clausen wrote:
> On 05/27/2014 03:04 PM, Peter Ujfalusi wrote:
>> Mark,
>>
>> On 05/27/2014 02:02 PM, Mark Brown wrote:
>>> On Tue, May 27, 2014 at 01:53:04PM +0300, Peter Ujfalusi wrote:
>>>> Hi,
>>>>
>>>> Commit "cf7c1de20c576 ASoC: dapm: Move 'value' field from widget to
>>>> control" changed the way how the 'value' has been stored for a widget.
>>>> This resulted issues with codec drivers needing and using custom dapm put
>>>> callbacks to handle the hw underneath, like the tlv320aic3x driver.
>>>> Since the driver is not updated following the mentioned commit it is mostly
>>>> broken when we try to change Left/Righ PGA mixers:
>>>
>>> Applied both, thanks.
>>
>> After discussing this with Lars over the IRC, would it be possible to drop
>> these patches? I'll come back with another set to fix this issue tomorrow.
> 
> 
> After giving some more though to the discussion from yesterday I think it is
> best to just find out why snd_soc_test_bits() returns -EINVAL and fix that and
> leave the rest as it is for now. Moving dapm_kcontrol_set_value() around is a
> bit more complicated than I thought.

I was thinking of moving the snd_soc_test_bits() to
snd_soc_dapm_mixer_update_power() and do the checks for the values in the
update. The return from snd_soc_dapm_mixer_update_power() will be true if
there's a change going to be and false when there is no need for the update to
run since the register is already in the same state.

But, yes, I'm looking at the failure, so far I do not see the reason. It
succeed when changing from off to on state and fails first when moving from on
to off, but succeed when trying the on -> off for the second time :o

-- 
Péter