* [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
@ 2014-10-10 14:32 Takashi Sakamoto
2014-10-10 15:05 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Sakamoto @ 2014-10-10 14:32 UTC (permalink / raw)
To: clemens, tiwai; +Cc: muranyia, alsa-devel, ffado-devel
This patch fixes a failure to open PCM device with -ENOSYS in
Terratec Phase 88.
Terratec Phase 88 has two Selector Function Blocks of AVC Audio subunit
to switch source of clock. One is to switch internal/external for the
source and another is to switch word/spdif for the external clock.
The IDs for these Selector Function Blocks are 9 and 8. But in current
implementation they're 0 and 0.
Reported-by: András Murányi <muranyia@gmail.com>
Tested-by: András Murányi <muranyia@gmail.com>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---
sound/firewire/bebob/bebob_terratec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/firewire/bebob/bebob_terratec.c b/sound/firewire/bebob/bebob_terratec.c
index eef8ea7..0e4c0bf 100644
--- a/sound/firewire/bebob/bebob_terratec.c
+++ b/sound/firewire/bebob/bebob_terratec.c
@@ -17,10 +17,10 @@ phase88_rack_clk_src_get(struct snd_bebob *bebob, unsigned int *id)
unsigned int enable_ext, enable_word;
int err;
- err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_ext);
+ err = avc_audio_get_selector(bebob->unit, 0, 9, &enable_ext);
if (err < 0)
goto end;
- err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_word);
+ err = avc_audio_get_selector(bebob->unit, 0, 8, &enable_word);
if (err < 0)
goto end;
--
1.9.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
2014-10-10 14:32 [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88 Takashi Sakamoto
@ 2014-10-10 15:05 ` Takashi Iwai
2014-10-10 15:22 ` Takashi Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2014-10-10 15:05 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: ffado-devel, alsa-devel, clemens, muranyia
At Fri, 10 Oct 2014 23:32:49 +0900,
Takashi Sakamoto wrote:
>
> This patch fixes a failure to open PCM device with -ENOSYS in
> Terratec Phase 88.
>
> Terratec Phase 88 has two Selector Function Blocks of AVC Audio subunit
> to switch source of clock. One is to switch internal/external for the
> source and another is to switch word/spdif for the external clock.
>
> The IDs for these Selector Function Blocks are 9 and 8. But in current
> implementation they're 0 and 0.
>
> Reported-by: András Murányi <muranyia@gmail.com>
> Tested-by: András Murányi <muranyia@gmail.com>
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
This deserves Cc to stable kernel, right?
Takashi
> ---
> sound/firewire/bebob/bebob_terratec.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/firewire/bebob/bebob_terratec.c b/sound/firewire/bebob/bebob_terratec.c
> index eef8ea7..0e4c0bf 100644
> --- a/sound/firewire/bebob/bebob_terratec.c
> +++ b/sound/firewire/bebob/bebob_terratec.c
> @@ -17,10 +17,10 @@ phase88_rack_clk_src_get(struct snd_bebob *bebob, unsigned int *id)
> unsigned int enable_ext, enable_word;
> int err;
>
> - err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_ext);
> + err = avc_audio_get_selector(bebob->unit, 0, 9, &enable_ext);
> if (err < 0)
> goto end;
> - err = avc_audio_get_selector(bebob->unit, 0, 0, &enable_word);
> + err = avc_audio_get_selector(bebob->unit, 0, 8, &enable_word);
> if (err < 0)
> goto end;
>
> --
> 1.9.1
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
2014-10-10 15:05 ` Takashi Iwai
@ 2014-10-10 15:22 ` Takashi Sakamoto
2014-10-10 15:58 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Sakamoto @ 2014-10-10 15:22 UTC (permalink / raw)
To: Takashi Iwai; +Cc: ffado-devel, alsa-devel, clemens, muranyia
Hi Iwai-san,
On Oct 11 2014 00:05, Takashi Iwai wrote:
>> Reported-by: András Murányi <muranyia@gmail.com>
>> Tested-by: András Murányi <muranyia@gmail.com>
>> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
>
> This deserves Cc to stable kernel, right?
Yes, please.
I did easy mistake when writing terratec module. I did just copy them
but forgot to change its parameters...
Regards
Takashi (Variety, one of the most important things in this world)
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
2014-10-10 15:22 ` Takashi Sakamoto
@ 2014-10-10 15:58 ` Takashi Iwai
2014-10-11 16:22 ` Takashi Sakamoto
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2014-10-10 15:58 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: ffado-devel, alsa-devel, clemens, muranyia
At Sat, 11 Oct 2014 00:22:38 +0900,
Takashi Sakamoto wrote:
>
> Hi Iwai-san,
>
> On Oct 11 2014 00:05, Takashi Iwai wrote:
> >> Reported-by: András Murányi <muranyia@gmail.com>
> >> Tested-by: András Murányi <muranyia@gmail.com>
> >> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> >
> > This deserves Cc to stable kernel, right?
>
> Yes, please.
>
> I did easy mistake when writing terratec module. I did just copy them
> but forgot to change its parameters...
Thanks, pulled now. It'll be included in the next pull request to
3.18-rc1 (slipped from today's one).
Takashi (dreaming of GUT)
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
2014-10-10 15:58 ` Takashi Iwai
@ 2014-10-11 16:22 ` Takashi Sakamoto
2014-10-13 5:55 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Sakamoto @ 2014-10-11 16:22 UTC (permalink / raw)
To: Takashi Iwai; +Cc: clemens, alsa-devel, ffado-devel, muranyia
Hi Iwai-san,
On Oct 11 2014 00:58, Takashi Iwai wrote:
>>> This deserves Cc to stable kernel, right?
>>
>> Yes, please.
>>
>> I did easy mistake when writing terratec module. I did just copy them
>> but forgot to change its parameters...
>
> Thanks, pulled now. It'll be included in the next pull request to
> 3.18-rc1 (slipped from today's one).
OK. Thanks.
FYI, I have a plan to prepare two patchsets for next merge window (Linux
3.19). One is for the Dice driver and another is for OXFW driver. I'll
post the OXFW driver till the beginning of November (if everything goes
well). Of cource, I welcome any discussions.
Regards
Takashi (dreaming of GUT between ALSA/FFADO)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88
2014-10-11 16:22 ` Takashi Sakamoto
@ 2014-10-13 5:55 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2014-10-13 5:55 UTC (permalink / raw)
To: Takashi Sakamoto; +Cc: clemens, alsa-devel, ffado-devel, muranyia
At Sun, 12 Oct 2014 01:22:14 +0900,
Takashi Sakamoto wrote:
>
> Hi Iwai-san,
>
> On Oct 11 2014 00:58, Takashi Iwai wrote:
> >>> This deserves Cc to stable kernel, right?
> >>
> >> Yes, please.
> >>
> >> I did easy mistake when writing terratec module. I did just copy them
> >> but forgot to change its parameters...
> >
> > Thanks, pulled now. It'll be included in the next pull request to
> > 3.18-rc1 (slipped from today's one).
>
> OK. Thanks.
>
> FYI, I have a plan to prepare two patchsets for next merge window (Linux
> 3.19). One is for the Dice driver and another is for OXFW driver. I'll
> post the OXFW driver till the beginning of November (if everything goes
> well). Of cource, I welcome any discussions.
Sounds like a good plan.
Thanks!
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-13 5:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 14:32 [PATCH] bebob: Fix failure to detect source of clock for Terratec Phase 88 Takashi Sakamoto
2014-10-10 15:05 ` Takashi Iwai
2014-10-10 15:22 ` Takashi Sakamoto
2014-10-10 15:58 ` Takashi Iwai
2014-10-11 16:22 ` Takashi Sakamoto
2014-10-13 5:55 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox