Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.jf.intel.com>,
	liam.r.girdwood@intel.com
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org,
	subhransu.s.prusty@intel.com, lgirdwood@gmail.com
Subject: Re: [PATCH v2 0/5] ASoC: Intel: ACPI support and machines
Date: Tue, 04 Nov 2014 11:05:34 +0200	[thread overview]
Message-ID: <545896DE.4030305@linux.intel.com> (raw)
In-Reply-To: <20141104082510.GC1870@intel.com>

Hi

On 11/04/2014 10:25 AM, Vinod Koul wrote:
> On Tue, Nov 04, 2014 at 10:09:40AM +0200, Jarkko Nikula wrote:
>>
>> I think there is need to have some consolidation with current
>> byt-rt5640 and byt-max98090. Since existing drivers and this set are
>> using the same ACPI IDs "80860F28" for the ADSP and "10EC5640" codec
>> ACPIID for the machine driver probing these drivers won't work
>> together.
> Liam's suggestion was to remove the current driver when all the bits are
> upstream

Yeah, I'm not against it but we must avoid regressions and perhaps try 
to do seamless handover if possible. It's always more nice to find 
regression in a small than big patch when bisecting :-)

>> One difference at the moment is that byt-rt5640 machines out there
>> have differences in audio routings but those are not too difficult
>> to handle in the same machine driver.
>>
>> Bigger question how to handle platform part? I.e. can these use the
>> same drivers and ADSP firmware? If they can, is the firmware
>> available for distributions to take?
> The two firmware are *not* compatible and that is the big reason why we
> can't reuse the parts available

Ok, so firmware appears to works on other than CR Baytrails too. Is it 
available in linux-firmware since if it's not when changing the platform 
drivers there will be obvious regressions to users?

>> Optimally all machines out there would use the same drivers and get
>> support for compressed audio but meanwhile we should not break
>> existing machines.
> Yes, I have tested this one on T100 and doesn't seem to break anything.
> Please do test and revert if you find issues on any other available board (I
> don't have any other board)
>
Well, those audio routing differences require to have DMI quirks. E.g. 
T100 has analogue internal mic, Dell Venue 8 Pro 5830 has digital mic 
connected to DMIC2 of the RT564x and some have it connected to DMIC1.

-- 
Jarkko

  reply	other threads:[~2014-11-04  9:05 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  5:31 [PATCH v2 0/5] ASoC: Intel: ACPI support and machines Vinod Koul
2014-11-04  5:31 ` [PATCH v2 1/5] ASoC: Intel: mrfld - remove unnecessary check for pointer Vinod Koul
2014-11-04  5:31 ` [PATCH v2 2/5] ASoC: Intel: mrfld - create separate module for pci part Vinod Koul
2014-11-04  5:31 ` [PATCH v2 3/5] ASoC: Intel: mrfld - add shim save restore Vinod Koul
2014-11-04  5:31 ` [PATCH v2 4/5] ASoC: Intel: mrfld- add ACPI module Vinod Koul
2014-11-04  5:31 ` [PATCH v2 5/5] ASoC: Intel: add BYTCR machine driver with RT5640 Vinod Koul
2014-11-04  9:19   ` Jarkko Nikula
2014-11-04  9:32     ` Vinod Koul
2014-11-05  7:54       ` Jarkko Nikula
2014-11-05  8:44         ` Vinod Koul
2014-11-04  8:09 ` [PATCH v2 0/5] ASoC: Intel: ACPI support and machines Jarkko Nikula
2014-11-04  8:25   ` Vinod Koul
2014-11-04  9:05     ` Jarkko Nikula [this message]
2014-11-04  9:15       ` Liam Girdwood
2014-11-04  9:31         ` Vinod Koul
2014-11-04  9:33       ` Vinod Koul
2014-11-04 11:15       ` Mark Brown
2014-11-05  7:49         ` Jarkko Nikula
2014-11-05  8:43           ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545896DE.4030305@linux.intel.com \
    --to=jarkko.nikula@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@linux.jf.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=liam.r.girdwood@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.de \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox