From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Nick Stoughton <nstoughton@aether.com>,
alsa-devel@alsa-project.org, Tim Cussins <timcussins@eml.cc>
Subject: Re: [PATCH RFC 5/9] ALSA: core: selection of audio_tstamp type and accuracy reports
Date: Thu, 11 Dec 2014 20:36:48 -0600 [thread overview]
Message-ID: <548A54C0.2050604@linux.intel.com> (raw)
In-Reply-To: <s5hiohi7muu.wl-tiwai@suse.de>
>> if someone used alsa-lib with the .get_wall_clock(), the new user-space
>> code will provide the same results as today, no change (wall clock if
>> supported, hw_ptr otherwise). So the library compatibility is preserved.
>
> You can't assume that all users always upgrade alsa-lib.
> Users may use still the old alsa-lib with the new kernel.
>
>> I don't mind adding a compatible kernel behavior for HDAudio only, but
>> is this really necessary?
>
> Yes, the kernel is not allowed to give any regression, if we know it
> would.
ok, will add a backwards-compatible mode. no problem.
>> I added a set of INFO defines and the matching is_supported queries in
>> alsa-lib. I just did a pretty dumb copy/paste/edit there, maybe we can
>> refactor the code here with a single routine taking a type parameter.
>> feedback welcome there.
>
> Right. But another concern is that this method will consume one INFO
> bit at each time the new tstamp type is extended. This is another
> concern. Exposing this information in another place would be better,
> IMO, if any better place is found...
I asked about this one in late October... I mentioned that we are
running out of INFO (half already used) and AZX_CAPS (28 bits used)
fields, and for INFO it didn't seem like a big deal.
If adding more fields to the info field is viewed as problematic, the
only options I can think of are:
- reclaim a reserved word in hw_params, e.g. rename to info1 to do
something like this in alsa-lib:
return !!(params->info1 & SNDRV_PCM_INFO1_IS_THIS_HARDWARE_BROKEN)
- keep a 32 bit word but add a paging register in the msb to reuse lsbs.
Either way some more code will be required in both driver and library.
next prev parent reply other threads:[~2014-12-12 2:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 22:23 [PATCH RFC 0/9] audio timestamping evolutions Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 1/9] ALSA: core: don't override timestamp unconditionally Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 2/9] ALSA: core: allow for trigger_tstamp snapshot in .trigger Pierre-Louis Bossart
2014-12-10 16:31 ` Takashi Iwai
2014-12-10 17:22 ` Pierre-Louis Bossart
2014-12-10 17:35 ` Takashi Iwai
2014-12-10 18:43 ` Pierre-Louis Bossart
2014-12-10 19:20 ` Takashi Iwai
2014-12-08 22:23 ` [PATCH RFC 3/9] ALSA: hda: read trigger_timestamp immediately after starting DMA Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 4/9] ALSA: usb: update trigger timestamp on first non-zero URB submitted Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 5/9] ALSA: core: selection of audio_tstamp type and accuracy reports Pierre-Louis Bossart
2014-12-10 16:35 ` Takashi Iwai
2014-12-10 17:27 ` Pierre-Louis Bossart
2014-12-10 17:39 ` Takashi Iwai
2014-12-10 20:08 ` Takashi Iwai
2014-12-10 21:48 ` Pierre-Louis Bossart
2014-12-10 22:27 ` Takashi Iwai
2014-12-10 23:04 ` Pierre-Louis Bossart
2014-12-11 5:54 ` Takashi Iwai
2014-12-12 2:36 ` Pierre-Louis Bossart [this message]
2014-12-12 8:37 ` Takashi Iwai
2014-12-12 15:20 ` Pierre-Louis Bossart
2014-12-14 15:03 ` Takashi Iwai
2014-12-16 14:01 ` Tim Cussins
2014-12-08 22:23 ` [PATCH RFC 6/9] ALSA: core: pass audio tstamp config from userspace Pierre-Louis Bossart
2014-12-10 17:28 ` Takashi Iwai
2014-12-10 17:35 ` Pierre-Louis Bossart
2014-12-10 17:40 ` Takashi Iwai
2014-12-08 22:23 ` [PATCH RFC 7/9] ALSA: core: pass audio tstamp config from userspace in compat mode Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 8/9] ALSA: core: replace .wall_clock by .get_time_info Pierre-Louis Bossart
2014-12-08 22:23 ` [PATCH RFC 9/9] ALSA: hda: replace .wallclock " Pierre-Louis Bossart
2014-12-10 4:40 ` [PATCH RFC 0/9] audio timestamping evolutions Raymond Yau
2014-12-10 14:55 ` Pierre-Louis Bossart
2014-12-12 4:55 ` Raymond Yau
2014-12-12 15:28 ` Pierre-Louis Bossart
2014-12-14 3:34 ` Raymond Yau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=548A54C0.2050604@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=nstoughton@aether.com \
--cc=timcussins@eml.cc \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox