From: Damien Zammit <damien@zamaudio.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>,
clemens@ladisch.de, tiwai@suse.de, robin@gareus.org
Cc: alsa-devel@alsa-project.org, ffado-devel@lists.sf.net
Subject: Re: [PATCH 11/11] ALSA: digi00x: apply double-oh-three algorism to multiplex PCM samples
Date: Mon, 16 Mar 2015 22:39:01 +1100 [thread overview]
Message-ID: <5506C0D5.7000909@zamaudio.com> (raw)
In-Reply-To: <1426435269-17059-12-git-send-email-o-takashi@sakamocchi.jp>
On 16/03/15 03:01, Takashi Sakamoto wrote:
> Digi 002/003 family uses own way to multiplex PCM samples into data
> blocks in CIP payload for received stream, thus AMDTP-conformant
> implementation causes noisy sound.
>
> This commit applies double-oh-three algorism, which discovered by Robin
> Gareus and Damien Zammit in 2012.
>
> As long as I tested, this patch still has disorder that:
> * 1st PCM channel still causes noise in 2nd PCM channel.
> * At 88.2/96.0kHz, any PCM channels still causes noise in the other PCM
> channels.
Can you please double check, I dont think snd_dg00x_protocol_write_s32()
is even being called because amdtp.c needs a small change to prevent
overriding the transmit_samples function pointer.
Damien
next prev parent reply other threads:[~2015-03-16 11:39 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 16:00 [RFC][PATCH 00/11] digi00x: new driver for Digidesign 002/003 family Takashi Sakamoto
2015-03-15 16:00 ` [PATCH 01/11] ALSA: digi00x: add skelton for Digi 002/003 device driver Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 02/11] ALSA: digi00x: add streaming functionality Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 03/11] ALSA: digi00x: add proc node for clock status Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 04/11] ALSA: digi00x: add PCM functionality Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 05/11] ALSA: digi00x: add MIDI functionality Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 06/11] ALSA: digi00x: add hwdep interface Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 07/11] ALSA: digi00x: support unknown asynchronous message Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 08/11] ALSA: digi00x: support MIDI ports for device control Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 09/11] ALSA: firewire-lib: allows to implement external MIDI callback function Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 10/11] digi00x: improve MIDI capture/playback Takashi Sakamoto
2015-03-15 16:01 ` [PATCH 11/11] ALSA: digi00x: apply double-oh-three algorism to multiplex PCM samples Takashi Sakamoto
2015-03-16 11:39 ` Damien Zammit [this message]
2015-03-16 13:24 ` Takashi Sakamoto
2015-03-16 14:25 ` Robin Gareus
2015-03-16 16:25 ` Takashi Sakamoto
2015-03-16 17:13 ` Robin Gareus
2015-03-16 22:47 ` Takashi Sakamoto
2015-03-17 13:37 ` Robin Gareus
2015-03-17 13:49 ` Damien Zammit
2015-03-18 1:06 ` Takashi Sakamoto
2015-03-19 5:18 ` Damien Zammit
2015-03-19 13:59 ` Robin Gareus
2015-03-19 22:46 ` Takashi Sakamoto
2015-03-19 22:51 ` Takashi Sakamoto
2015-03-20 12:05 ` firewire mixer interface -- was " Robin Gareus
2015-03-20 13:00 ` Clemens Ladisch
2015-03-20 13:25 ` Takashi Sakamoto
2015-03-20 13:35 ` Takashi Iwai
2015-03-20 13:51 ` Takashi Sakamoto
2015-03-20 14:13 ` Takashi Iwai
2015-03-20 14:45 ` Takashi Sakamoto
2015-03-20 15:01 ` Takashi Iwai
2015-03-21 5:59 ` Damien Zammit
2015-03-22 2:55 ` Takashi Sakamoto
2015-03-22 5:56 ` [FFADO-devel] " Jonathan Woithe
2015-03-24 3:15 ` Robin Gareus
2015-03-20 13:55 ` Damien Zammit
2015-03-20 14:07 ` Clemens Ladisch
2015-03-22 6:11 ` [FFADO-devel] " Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5506C0D5.7000909@zamaudio.com \
--to=damien@zamaudio.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
--cc=robin@gareus.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox