From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
Hardik T Shah <hardik.t.shah@intel.com>,
liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [RFC 6/7] ASoC: hda: Add support for SSP register settings
Date: Wed, 29 Apr 2015 18:45:11 -0500 [thread overview]
Message-ID: <55416D07.6060204@linux.intel.com> (raw)
In-Reply-To: <20150427141509.GS22845@sirena.org.uk>
On 4/27/15 9:15 AM, Mark Brown wrote:
> On Sun, Apr 26, 2015 at 07:48:31PM +0530, Vinod Koul wrote:
>> On Fri, Apr 24, 2015 at 06:55:32PM +0100, Mark Brown wrote:
>
>>>> + /* Dont add odd number of dummy bits, since I2S requires
>>>> + * dummy bit after each slot/channel
>>>> + */
>
>>> It does?
>
>> For us unfortuntely yes. We send 24 bit audio to codec and clock divider
>> doesn't give us 48clocks per frame, so we have to add dummy clocks in each
>> slot and send 25 clocks per slot
>
> So it's the hardware rather than I2S itself :)
It depends on the clock reference used to drive the SSP. With a 19.2
reference we typically divide by 50 and pad with a trailing bit.
That said I am not sure how this code would work on SKL. Vinod, isn't
this for BXT only? how do you get 19.2 on SKL, shouldn't you guys use a
24 MHz root frequency to find the divider?
next prev parent reply other threads:[~2015-04-29 23:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 20:57 [RFC 0/7] ASoC: hda - ASoC DSP widget event handlers Vinod Koul
2015-04-18 20:57 ` [RFC 1/7] ASoC: hda: Add skl dsp init and registering with SST IPC lib Vinod Koul
2015-04-24 17:36 ` Mark Brown
2015-04-26 13:53 ` Vinod Koul
2015-04-18 20:57 ` [RFC 2/7] ASoC: hda: add helper to configure module params Vinod Koul
2015-04-24 17:38 ` Mark Brown
2015-04-26 14:06 ` Vinod Koul
2015-04-18 20:57 ` [RFC 3/7] ASoC: hda: add FW module init/bind IPC Vinod Koul
2015-04-18 20:57 ` [RFC 4/7] ASoC: hda: add FW pipe create/delete/set_pipe_state IPC Vinod Koul
2015-04-18 20:57 ` [RFC 5/7] ASOC: hda: add DSP platfrom controls widget event handlers Vinod Koul
2015-04-24 17:51 ` Mark Brown
2015-04-26 14:14 ` Vinod Koul
2015-04-18 20:57 ` [RFC 6/7] ASoC: hda: Add support for SSP register settings Vinod Koul
2015-04-24 17:55 ` Mark Brown
2015-04-26 14:18 ` Vinod Koul
2015-04-27 14:15 ` Mark Brown
2015-04-29 23:45 ` Pierre-Louis Bossart [this message]
2015-04-29 23:50 ` Pierre-Louis Bossart
2015-04-30 4:39 ` Vinod Koul
2015-04-30 14:36 ` Mark Brown
2015-04-30 15:55 ` Pierre-Louis Bossart
2015-04-18 20:57 ` [RFC 7/7] ASoC: hda: Apply dai params_fixup for DSP widgets Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55416D07.6060204@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=hardik.t.shah@intel.com \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox