Re: [RFC PATCH 1/2] ALSA: hda - add hda_dev_t typedef for DP MST audio

[Libin Yang <libin.yang@linux.intel.com>]

On 11/04/2015 12:28 AM, Takashi Iwai wrote:
> On Tue, 03 Nov 2015 09:22:52 +0100,
> libin.yang@linux.intel.com wrote:
>>
>> From: Libin Yang <libin.yang@intel.com>
>>
>> Signed-off-by: Libin Yang <libin.yang@intel.com>
>> ---
>>   include/sound/hdaudio.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
>> index e2b712c..1f54964 100644
>> --- a/include/sound/hdaudio.h
>> +++ b/include/sound/hdaudio.h
>> @@ -15,6 +15,7 @@
>>
>>   /* codec node id */
>>   typedef u16 hda_nid_t;
>> +typedef u8 hda_dev_t;
>
> This isn't used in any ABI, so we don't have to define the type.
> Just use int instead.
>
> NID was defined there because it's used in ABI and it can represent
> the purpose more clearly.  (Also at the early time of driver writing,
> the size itself wasn't 100% clear; we started writing it before
> HD-audio spec got solid.)

OK. I will use int type directly.

Best Regards,
Libin

>
>
> thanks,
>
> Takashi
>