Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: libin.yang@linux.intel.com
Cc: Libin Yang <libin.yang@intel.com>,
	alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com
Subject: Re: [RFC PATCH 1/2] ALSA: hda - add hda_dev_t typedef for DP MST audio
Date: Tue, 03 Nov 2015 17:28:10 +0100	[thread overview]
Message-ID: <s5hvb9jnj39.wl-tiwai@suse.de> (raw)
In-Reply-To: <1446538973-109373-2-git-send-email-libin.yang@linux.intel.com>

On Tue, 03 Nov 2015 09:22:52 +0100,
libin.yang@linux.intel.com wrote:
> 
> From: Libin Yang <libin.yang@intel.com>
> 
> Signed-off-by: Libin Yang <libin.yang@intel.com>
> ---
>  include/sound/hdaudio.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/sound/hdaudio.h b/include/sound/hdaudio.h
> index e2b712c..1f54964 100644
> --- a/include/sound/hdaudio.h
> +++ b/include/sound/hdaudio.h
> @@ -15,6 +15,7 @@
>  
>  /* codec node id */
>  typedef u16 hda_nid_t;
> +typedef u8 hda_dev_t;

This isn't used in any ABI, so we don't have to define the type.
Just use int instead.

NID was defined there because it's used in ABI and it can represent
the purpose more clearly.  (Also at the early time of driver writing,
the size itself wasn't 100% clear; we started writing it before
HD-audio spec got solid.)


thanks,

Takashi

  reply	other threads:[~2015-11-03 16:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-03  8:22 [RFC PATCH 0/2] ALSA: hda - patch set for DP MST audio support libin.yang
2015-11-03  8:22 ` [RFC PATCH 1/2] ALSA: hda - add hda_dev_t typedef for DP MST audio libin.yang
2015-11-03 16:28   ` Takashi Iwai [this message]
2015-11-04  2:37     ` Libin Yang
2015-11-03  8:22 ` [RFC PATCH 2/2] ALSA: hda - HDMI codec driver dynamically attach PCM libin.yang
2015-11-03 16:44   ` Takashi Iwai
2015-11-04  5:38     ` Libin Yang
2015-11-04  7:55       ` Libin Yang
2015-11-06  5:33       ` Libin Yang
2015-11-06  9:12         ` Takashi Iwai
2015-11-09  1:38           ` Libin Yang
2015-11-09  7:55             ` Takashi Iwai
2015-11-09  8:45               ` Libin Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hvb9jnj39.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=libin.yang@intel.com \
    --cc=libin.yang@linux.intel.com \
    --cc=mengdong.lin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox