Re: [PATCH] ALSA: hda: Refactor Intel NHLT init

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2020-04-23 14:15, Takashi Iwai wrote:
> On Thu, 23 Apr 2020 13:40:10 +0200,
> Cezary Rojewski wrote:
>>
>> On 2020-04-23 13:24, Takashi Iwai wrote:
>>> On Thu, 23 Apr 2020 13:21:36 +0200,
>>> Cezary Rojewski wrote:
>>>>
>>>> NHLT fetch based on _DSM prevents ACPI table override mechanism from
>>>> being utilized. Make use of acpi_get_table to enable it and get rid of
>>>> redundant code.
>>>>
>>>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>>>
>>> This looks like a nice cleanup and I'll happily apply if anyone can
>>> test with the actual hardware -- currently mine has no DSP, so unable
>>> to check.
>>>
>>>
>>> thanks,
>>>
>>> Takashi
>>>
>>
>> NHLT override method has been added for internal use half a year ago
>> and is for some time the default method within our CI. This is tested
>> on a wide spread of hardware, that is any Intel AVS archtecture,
>> including production laptops.
> 
> This could be mentioned in the changelog, otherwise we have no idea
> about the test coverage.
> 

My apologizes Takashi, indeed I should have mentioned that :(

I've forgotten about one more positive news:
https://bugs.acpica.org/show_bug.cgi?id=1525

Robert is working on official NHLT support for iASL. Currently, only 
header gets decompilled while the rest is dumped as binary array.

Do you want me to resubmit the patch with this entire info appended to 
the commit message?

Czarek