From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com
Subject: Re: [PATCH] ALSA: hda: Refactor Intel NHLT init
Date: Thu, 23 Apr 2020 13:40:10 +0200 [thread overview]
Message-ID: <b37cb05b-f4c2-e747-c3f0-1582ed3afadd@intel.com> (raw)
In-Reply-To: <s5hd07ywikl.wl-tiwai@suse.de>
On 2020-04-23 13:24, Takashi Iwai wrote:
> On Thu, 23 Apr 2020 13:21:36 +0200,
> Cezary Rojewski wrote:
>>
>> NHLT fetch based on _DSM prevents ACPI table override mechanism from
>> being utilized. Make use of acpi_get_table to enable it and get rid of
>> redundant code.
>>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>
> This looks like a nice cleanup and I'll happily apply if anyone can
> test with the actual hardware -- currently mine has no DSP, so unable
> to check.
>
>
> thanks,
>
> Takashi
>
NHLT override method has been added for internal use half a year ago and
is for some time the default method within our CI. This is tested on a
wide spread of hardware, that is any Intel AVS archtecture, including
production laptops.
Actual override works like any SSDT/ DSDT, e.g. usage can be found at:
https://github.com/thesofproject/acpi-scripts
and original:
https://wiki.up-community.org/Pinout_UP2#Installing_ACPI_overrides_to_enable_spi_in_userspace
Early this year I've pushed the initiative to finally shatter bounds of
mystery surrounding NHLT in Linux and make it available to community.
Erik and Robert helped me in ACPICA part, patch link:
https://patchwork.kernel.org/patch/11463235/
Spec can now be found at:
https://01.org/blogs/intel-smart-sound-technology-audio-dsp
This has been sanctioned by Intel Legal and acked by Marcin Obara, NHLT
author so no worries about spec disappearing like it did in 2016.
Czarek
next prev parent reply other threads:[~2020-04-23 11:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 11:21 [PATCH] ALSA: hda: Refactor Intel NHLT init Cezary Rojewski
2020-04-23 11:24 ` Takashi Iwai
2020-04-23 11:40 ` Cezary Rojewski [this message]
2020-04-23 12:15 ` Takashi Iwai
2020-04-23 12:21 ` Cezary Rojewski
2020-04-23 12:24 ` Takashi Iwai
2020-04-23 16:29 ` Pierre-Louis Bossart
2020-04-23 17:10 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b37cb05b-f4c2-e747-c3f0-1582ed3afadd@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox