Re: kismet: WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH

Re: kismet: WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH

[Pierre-Louis Bossart]

On 5/10/22 22:36, kernel test robot wrote:
> tree:  
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   feb9c5e19e913b53cb536a7aa7c9f20107bb51ec
> commit: 5a7f27a624d9e33262767b328aa7a4baf7846c14 ASoC: Intel: add
> sof-cs42l42 machine driver
> date:   1 year ago
> config: (attached as .config)
> reproduce:
>         #
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=5a7f27a624d9e33262767b328aa7a4baf7846c14
> 
>         git remote add linus
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>         git fetch --no-tags linus master
>         git checkout 5a7f27a624d9e33262767b328aa7a4baf7846c14
>         # 1. reproduce by kismet
>            # install kmax per https://github.com/paulgazz/kmax/README.md
>            kismet --linux-ksrc=linux --selectees
> CONFIG_SND_SOC_MAX98357A --selectors
> CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH -a=x86_64
>         # 2. reproduce by make
>            # save the config file to linux source tree
>            cd linux
>            make ARCH=x86_64 olddefconfig
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <yujie.liu@intel.com>
> 
> 
> kismet warnings: (new ones prefixed by >>)
>>> kismet: WARNING: unmet direct dependencies detected for
> SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
> 
>    WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
> GPIOLIB [=n]
>      Selected by [y]:
>      - SND_SOC_INTEL_SOF_CS42L42_MACH [=y] && SOUND [=y] && !UML && SND
> [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK
> [=y] || SND_SOC_SOF_BAYTRAIL [=n]) && I2C [=y] && ACPI [=y] &&
> SND_HDA_CODEC_HDMI [=y] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] &&
> (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])

I can reproduce this, but I question the hard dependency on GPIOLIB in
the amplifier Kconfig:

	max98357a->sdmode = devm_gpiod_get_optional(&pdev->dev,
				"sdmode", GPIOD_OUT_LOW);

If the gpio is optional, max98357a.c should build and compile without
GPIOLIB, no?


>    WARNING: unmet direct dependencies detected for SND_SOC_DMIC
>      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
> GPIOLIB [=n]
>      Selected by [y]:
>      - SND_SOC_INTEL_SOF_CS42L42_MACH [=y] && SOUND [=y] && !UML && SND
> [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK
> [=y] || SND_SOC_SOF_BAYTRAIL [=n]) && I2C [=y] && ACPI [=y] &&
> SND_HDA_CODEC_HDMI [=y] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] &&
> (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])

I can't reproduce this one with Mark's for-next branch, this was fixed I
believe.

Re: kismet: WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH

[Pierre-Louis Bossart]

>>>> kismet: WARNING: unmet direct dependencies detected for
>> SND_SOC_MAX98357A when selected by SND_SOC_INTEL_SOF_CS42L42_MACH
>>
>>    WARNING: unmet direct dependencies detected for SND_SOC_MAX98357A
>>      Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] &&
>> GPIOLIB [=n]
>>      Selected by [y]:
>>      - SND_SOC_INTEL_SOF_CS42L42_MACH [=y] && SOUND [=y] && !UML && SND
>> [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && (SND_SOC_SOF_HDA_LINK
>> [=y] || SND_SOC_SOF_BAYTRAIL [=n]) && I2C [=y] && ACPI [=y] &&
>> SND_HDA_CODEC_HDMI [=y] && SND_SOC_SOF_HDA_AUDIO_CODEC [=y] &&
>> (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n])
> 
> I can reproduce this, but I question the hard dependency on GPIOLIB in
> the amplifier Kconfig:
> 
> 	max98357a->sdmode = devm_gpiod_get_optional(&pdev->dev,
> 				"sdmode", GPIOD_OUT_LOW);
> 
> If the gpio is optional, max98357a.c should build and compile without
> GPIOLIB, no?

The warning goes away with the patch suggested in
https://github.com/thesofproject/linux/pull/3646

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig

index b106e55170904..8536773548090 100644

--- a/sound/soc/codecs/Kconfig

+++ b/sound/soc/codecs/Kconfig

@@ -986,7 +986,6 @@ config SND_SOC_MAX98095



 config SND_SOC_MAX98357A

        tristate "Maxim MAX98357A CODEC"

-       depends on GPIOLIB



 config SND_SOC_MAX98371

        tristate