From: bugtrack@alsa-project.org
To: alsa-devel@alsa-project.org
Subject: [ALSA - driver 0001208]: 2 Typos and a little Question to device.c
Date: Thu, 23 Jun 2005 12:14:24 +0200 [thread overview]
Message-ID: <748fc00dbd12dbbed98cbb3ebc98272d@bugtrack.alsa-project.org> (raw)
A NOTE has been added to this issue.
======================================================================
<https://bugtrack.alsa-project.org/alsa-bug/view.php?id=1208>
======================================================================
Reported By: Henne
Assigned To:
======================================================================
Project: ALSA - driver
Issue ID: 1208
Category: 1_OTHERS
Reproducibility: always
Severity: text
Priority: normal
Status: new
Distribution:
Kernel Version:
======================================================================
Date Submitted: 06-22-2005 23:58 CEST
Last Modified: 06-23-2005 12:14 CEST
======================================================================
Summary: 2 Typos and a little Question to device.c
Description:
The comment @type of snd_device_new() is wrong. I belive it has to be
SNDDRV_DEV_XXX instead of SNDDRV_DEV_TYPE_XXX .
The comment in snd_device_disconnect() has to be snd_device_disconnect
instead of snd_device_free.
The sound_assert() macros in snd_device_new() and snd_device_register()
have a couple of expessions, and I belive it would be better for debuggin
if the macro calls would be called for paramter seperately, like in all
the other functions.
======================================================================
----------------------------------------------------------------------
tiwai - 06-23-05 10:50
----------------------------------------------------------------------
Agreed. Patches are welcome :)
(See NEWS section for the detail how to write a patch.)
----------------------------------------------------------------------
Henne - 06-23-05 12:14
----------------------------------------------------------------------
Here we go!
Issue History
Date Modified Username Field Change
======================================================================
06-22-05 23:58 Henne New Issue
06-23-05 10:50 tiwai Note Added: 0005166
06-23-05 12:12 Henne File Added: device-patch.diff
06-23-05 12:14 Henne Note Added: 0005179
======================================================================
-------------------------------------------------------
SF.Net email is sponsored by: Discover Easy Linux Migration Strategies
from IBM. Find simple to follow Roadmaps, straightforward articles,
informative Webcasts and more! Get everything you need to get up to
speed, fast. http://ads.osdn.com/?ad_id=7477&alloc_id=16492&op=click
next reply other threads:[~2005-06-23 10:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 10:14 bugtrack [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-29 18:32 [ALSA - driver 0001208]: 2 Typos and a little Question to device.c bugtrack
2005-06-23 8:50 bugtrack
2005-06-22 21:58 bugtrack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748fc00dbd12dbbed98cbb3ebc98272d@bugtrack.alsa-project.org \
--to=bugtrack@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox