* [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1
@ 2020-09-01 8:06 Hans de Goede
2020-09-01 13:16 ` Pierre-Louis Bossart
2020-09-02 18:54 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2020-09-01 8:06 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown
Cc: Hans de Goede, alsa-devel
The MPMAN Converter9 2-in-1 almost fully works with out default settings.
The only problem is that it has only 1 speaker so any sounds only playing
on the right channel get lost.
Add a quirk for this model using the default settings + MONO_SPEAKER.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/soc/intel/boards/bytcr_rt5640.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 479992f4e97a..fc202747ba83 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -591,6 +591,16 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
BYT_RT5640_SSP0_AIF1 |
BYT_RT5640_MCLK_EN),
},
+ { /* MPMAN Converter 9, similar hw as the I.T.Works TW891 2-in-1 */
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "MPMAN"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "Converter9"),
+ },
+ .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+ BYT_RT5640_MONO_SPEAKER |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
+ },
{
/* MPMAN MPWIN895CL */
.matches = {
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1
2020-09-01 8:06 [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1 Hans de Goede
@ 2020-09-01 13:16 ` Pierre-Louis Bossart
2020-09-02 18:54 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Pierre-Louis Bossart @ 2020-09-01 13:16 UTC (permalink / raw)
To: Hans de Goede, Cezary Rojewski, Liam Girdwood, Jie Yang,
Mark Brown
Cc: alsa-devel
On 9/1/20 3:06 AM, Hans de Goede wrote:
> The MPMAN Converter9 2-in-1 almost fully works with out default settings.
> The only problem is that it has only 1 speaker so any sounds only playing
> on the right channel get lost.
>
> Add a quirk for this model using the default settings + MONO_SPEAKER.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Hans!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1
2020-09-01 8:06 [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1 Hans de Goede
2020-09-01 13:16 ` Pierre-Louis Bossart
@ 2020-09-02 18:54 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2020-09-02 18:54 UTC (permalink / raw)
To: Jie Yang, Hans de Goede, Liam Girdwood, Pierre-Louis Bossart,
Cezary Rojewski
Cc: alsa-devel
On Tue, 1 Sep 2020 10:06:23 +0200, Hans de Goede wrote:
> The MPMAN Converter9 2-in-1 almost fully works with out default settings.
> The only problem is that it has only 1 speaker so any sounds only playing
> on the right channel get lost.
>
> Add a quirk for this model using the default settings + MONO_SPEAKER.
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1
commit: 6a0137101f47301fff2da6ba4b9048383d569909
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-02 18:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-01 8:06 [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN Converter9 2-in-1 Hans de Goede
2020-09-01 13:16 ` Pierre-Louis Bossart
2020-09-02 18:54 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox