Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Cc: tiwai@suse.com, perex@perex.cz, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: scarlett_gen2: Fix another -Wformat-truncation warning
Date: Tue, 19 Sep 2023 09:19:16 +0200	[thread overview]
Message-ID: <875y46zl3f.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230919071205.10684-1-peter.ujfalusi@linux.intel.com>

On Tue, 19 Sep 2023 09:12:05 +0200,
Peter Ujfalusi wrote:
> 
> The recent enablement of -Wformat-truncation leads to a false-positive
> warning for mixer_scarlett_gen2.c.
> 
> For suppressing the warning, replace snprintf() with scnprintf().
> As stated in the above, truncation doesn't matter.
> 
> Fixes: 78bd8f5126f8 ("ALSA: usb-audio: scarlett_gen2: Fix -Wformat-truncation warning")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>

While I applied it now, I wonder why this didn't show up with my local
test.  Which compiler are you using?


thanks,

Takashi

  reply	other threads:[~2023-09-19  7:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  7:12 [PATCH] ALSA: usb-audio: scarlett_gen2: Fix another -Wformat-truncation warning Peter Ujfalusi
2023-09-19  7:19 ` Takashi Iwai [this message]
2023-09-19  7:22   ` Péter Ujfalusi
2023-09-19  7:41     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y46zl3f.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox