Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Naresh Kamboju <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] ALSA: emu10k1: remove runtime 64-bit divisions
Date: Wed, 17 May 2023 22:18:50 +0200	[thread overview]
Message-ID: <875y8q1zkl.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230517164800.3650699-1-oswald.buddenhagen@gmx.de>

On Wed, 17 May 2023 18:48:00 +0200,
Oswald Buddenhagen wrote:
> 
> 32-bit platforms don't like these. As we're actually dealing with
> constants, factor out the calculations and pass them in as additional
> arguments. To keep the call sites clean, wrap the actual functions in
> macros which generate the arguments.
> 
> Fixes: bb5ceb43b7bf ("ALSA: emu10k1: fix non-zero mixer control defaults in highres mode")
> Fixes: 1298bc978afb ("ALSA: emu10k1: enable bit-exact playback, part 1: DSP attenuation")
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> 
> ---
> 
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Naresh Kamboju <naresh.kamboju@linaro.org>
> ---

Thanks, applied now.


Takashi

      parent reply	other threads:[~2023-05-17 20:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 16:48 [PATCH] ALSA: emu10k1: remove runtime 64-bit divisions Oswald Buddenhagen
2023-05-17 16:55 ` Christophe Leroy
2023-05-17 20:18 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y8q1zkl.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=naresh.kamboju@linaro.org \
    --cc=oswald.buddenhagen@gmx.de \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox