From: Takashi Iwai <tiwai@suse.de>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Abaci Robot <abaci@linux.alibaba.com>,
tiwai@suse.com
Subject: Re: [PATCH] ALSA: emu10k1: clean up some inconsistent indenting
Date: Wed, 01 Feb 2023 13:12:28 +0100 [thread overview]
Message-ID: <87a61xy47n.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230131084304.12920-1-jiapeng.chong@linux.alibaba.com>
On Tue, 31 Jan 2023 09:43:04 +0100,
Jiapeng Chong wrote:
>
> No functional modification involved.
>
> sound/pci/emu10k1/memory.c:446 snd_emu10k1_synth_free() warn: inconsistent indenting.
How is this warning generated? Does it come from clang or any other
compiler, or is it just some tool?
In general, I take such a white-space-fix-only patch when it's tied
with other real fix patches. But if the compiler warns, it's worth to
pick up, of course.
thanks,
Takashi
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3903
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> sound/pci/emu10k1/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/pci/emu10k1/memory.c b/sound/pci/emu10k1/memory.c
> index edb3f1763719..6a7406014f81 100644
> --- a/sound/pci/emu10k1/memory.c
> +++ b/sound/pci/emu10k1/memory.c
> @@ -443,7 +443,7 @@ snd_emu10k1_synth_free(struct snd_emu10k1 *emu, struct snd_util_memblk *memblk)
> unmap_memblk(emu, blk);
> spin_unlock_irqrestore(&emu->memblk_lock, flags);
> synth_free_pages(emu, blk);
> - __snd_util_mem_free(hdr, memblk);
> + __snd_util_mem_free(hdr, memblk);
> mutex_unlock(&hdr->block_mutex);
> return 0;
> }
> --
> 2.20.1.7.g153144c
>
prev parent reply other threads:[~2023-02-01 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 8:43 [PATCH] ALSA: emu10k1: clean up some inconsistent indenting Jiapeng Chong
2023-02-01 12:12 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a61xy47n.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=abaci@linux.alibaba.com \
--cc=alsa-devel@alsa-project.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox