[alsa-devel] wm9713 regression on pxa platforms

[alsa-devel] wm9713 regression on pxa platforms

[Robert Jarzmik]

Hi Wolfson maintainers, hi Mark,

Recently, the wm9713 support broke on my platforms. I'm pretty sure that a
previous harmless warning became an error preventing the probe of my driver
(sound/soc/pxa/mioa701_wm9713.c) : the error is shown in [1] ("Control not
supported").

The warning "ASoC: no dapm match for Mic B Source" has be there as far as I'm
aware for ages, and it never prevented the probe before.

Now, if I apply the ugly patch in [2], everything works as expected ... but
that's definitely not the right fix.

Would any of you be able to figure out a fix please ?

Cheers.

-- 
Robert

[1] Kernel log
[  129.888985] pxa2xx-ac97 pxa2xx-ac97: ASoC: dai register pxa2xx-ac97 #3
[  129.889052] pxa2xx-ac97 pxa2xx-ac97: ASoC: dynamically register DAI pxa2xx-ac97
[  129.889102] pxa2xx-ac97 pxa2xx-ac97: ASoC: Registered DAI 'pxa2xx-ac97'
[  129.889135] pxa2xx-ac97 pxa2xx-ac97: ASoC: dynamically register DAI pxa2xx-ac97
[  129.889176] pxa2xx-ac97 pxa2xx-ac97: ASoC: Registered DAI 'pxa2xx-ac97-aux'
[  129.889207] pxa2xx-ac97 pxa2xx-ac97: ASoC: dynamically register DAI pxa2xx-ac97
[  129.889249] pxa2xx-ac97 pxa2xx-ac97: ASoC: Registered DAI 'pxa2xx-ac97-mic'
[  135.341942] wm9713-codec wm9713-codec: ASoC: dai register wm9713-codec #3
[  135.342019] wm9713-codec wm9713-codec: ASoC: dynamically register DAI wm9713-codec
[  135.342077] wm9713-codec wm9713-codec: ASoC: Registered DAI 'wm9713-hifi'
[  135.342109] wm9713-codec wm9713-codec: ASoC: dynamically register DAI wm9713-codec
[  135.342162] wm9713-codec wm9713-codec: ASoC: Registered DAI 'wm9713-aux'
[  135.342193] wm9713-codec wm9713-codec: ASoC: dynamically register DAI wm9713-codec
[  135.342234] wm9713-codec wm9713-codec: ASoC: Registered DAI 'wm9713-voice'
[  139.362113] mioa701-wm9713 mioa701-wm9713: ASoC: binding AC97
[  139.362302] mioa701-wm9713 mioa701-wm9713: ASoC: binding AC97 Aux
[  139.367170] wm9713-codec wm9713-codec: Control not supported for path Mic B Source -> [MPB] -> Mic B Pre Amp
[  139.375450] wm9713-codec wm9713-codec: ASoC: no dapm match for Mic B Source --> MPB --> Mic B Pre Amp
[  139.383448] wm9713-codec wm9713-codec: ASoC: Failed to add route Mic B Source -> MPB -> Mic B Pre Amp
[  139.393422] mioa701-wm9713 mioa701-wm9713: ASoC: failed to instantiate card -22
[  139.403089] mioa701-wm9713: probe of mioa701-wm9713 failed with error -22

[2] Ugly test
diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c
index 6497c1ea6228..ec140ccbab0b 100644
--- a/sound/soc/codecs/wm9713.c
+++ b/sound/soc/codecs/wm9713.c
@@ -630,8 +630,8 @@ static const struct snd_soc_dapm_route wm9713_audio_map[] = {
        {"Mic A Source", "Mic 1", "MIC1"},
        {"Mic A Source", "Mic 2 A", "MIC2A"},
        {"Mic A Source", "Mic 2 B", "Mic B Source"},
-       {"Mic B Pre Amp", "MPB", "Mic B Source"},
-       {"Mic B Source", NULL, "MIC2B"},
+       /* {"Mic B Pre Amp", "MPB", "Mic B Source"}, */
+       /* {"Mic B Source", NULL, "MIC2B"}, */
 
        /* headphone capture */
        {"Capture Headphone Mux", "Stereo", "Capture Mixer"},
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] wm9713 regression on pxa platforms

[Charles Keepax]

On Sat, Oct 26, 2019 at 10:06:10PM +0200, Robert Jarzmik wrote:
> Hi Wolfson maintainers, hi Mark,
> 
> Recently, the wm9713 support broke on my platforms. I'm pretty sure that a
> previous harmless warning became an error preventing the probe of my driver
> (sound/soc/pxa/mioa701_wm9713.c) : the error is shown in [1] ("Control not
> supported").
> 
> The warning "ASoC: no dapm match for Mic B Source" has be there as far as I'm
> aware for ages, and it never prevented the probe before.
> 
> Now, if I apply the ugly patch in [2], everything works as expected ... but
> that's definitely not the right fix.
> 
> Would any of you be able to figure out a fix please ?
> 

I suspect the patch that turned this into a fatal error was this
one:

daa480bde6b3 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()")

That said the error is clearly valid and the driver should be
fixed. The routes make no sense and are clearly wrong. I strongly
suspect the routes should look like this:

{"Mic B Pre Amp", NULL, "Mic B Source"},
{"Mic B Source", "MPB", "MIC2B"},

I am travelling this week, and would need to do a bit more
datasheet diving to be sure. But be worth checking if that fixes
it and I can fire out a real patch start of next week.

Thanks,
Charles

> [2] Ugly test
> diff --git a/sound/soc/codecs/wm9713.c b/sound/soc/codecs/wm9713.c
> index 6497c1ea6228..ec140ccbab0b 100644
> --- a/sound/soc/codecs/wm9713.c
> +++ b/sound/soc/codecs/wm9713.c
> @@ -630,8 +630,8 @@ static const struct snd_soc_dapm_route wm9713_audio_map[] = {
>         {"Mic A Source", "Mic 1", "MIC1"},
>         {"Mic A Source", "Mic 2 A", "MIC2A"},
>         {"Mic A Source", "Mic 2 B", "Mic B Source"},
> -       {"Mic B Pre Amp", "MPB", "Mic B Source"},
> -       {"Mic B Source", NULL, "MIC2B"},
> +       /* {"Mic B Pre Amp", "MPB", "Mic B Source"}, */
> +       /* {"Mic B Source", NULL, "MIC2B"}, */
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [alsa-devel] wm9713 regression on pxa platforms

[Robert Jarzmik]

Charles Keepax <ckeepax@opensource.cirrus.com> writes:

> {"Mic B Pre Amp", NULL, "Mic B Source"},
> {"Mic B Source", "MPB", "MIC2B"},
That fixes it on my side.
>
> I am travelling this week, and would need to do a bit more
> datasheet diving to be sure. But be worth checking if that fixes
> it and I can fire out a real patch start of next week.
Ok, once you're back, you can added my :
Tested-by: Robert Jarzmik <robert.jarzmik.fr>

Cheers.

--
Robert
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel