Re: [PATCH] ASoC: pxa: remove clock divider and pll setup from zylonite and magician

[Robert Jarzmik <robert.jarzmik@free.fr>]

Daniel Mack <daniel@zonque.org> writes:

> The SSP DAI now handles the clocking setup itself, all it needs is the
> master clock frequency. Remove the code from Zylonite and Magician
> platforms.
>
> Signed-off-by: Daniel Mack <daniel@zonque.org>
> ---
>  sound/soc/pxa/magician.c | 105 +--------------------------------------
>  sound/soc/pxa/zylonite.c |   9 ----
>  2 files changed, 1 insertion(+), 113 deletions(-)
>
> diff --git a/sound/soc/pxa/magician.c b/sound/soc/pxa/magician.c
> index 2fc012b06c43..2746725a898c 100644
> --- a/sound/soc/pxa/magician.c
> +++ b/sound/soc/pxa/magician.c
> @@ -90,95 +90,9 @@ static int magician_playback_hw_params(struct snd_pcm_substream *substream,
>  	struct snd_soc_pcm_runtime *rtd = substream->private_data;
>  	struct snd_soc_dai *codec_dai = rtd->codec_dai;
>  	struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
> -	unsigned int acps, acds, width;
> -	unsigned int div4 = PXA_SSP_CLK_SCDB_4;
> +	unsigned int width;
>  	int ret = 0;
>  
> -	width = snd_pcm_format_physical_width(params_format(params));
Ok so width is not initialized anymore ...
Either it is used and an assignement should be there somewhere, or it is not
used and the declaration is not necessary .

Or width is assigned in a former patch I didn't apply and I don't see it in my
branch ...

Cheers.

-- 
Robert