Re: How to add 2 different SND_PCI_QUIRKs for 2 models with the same PCI subsys vend + prod ids?

[Takashi Iwai <tiwai@suse.de>]

On Mon, 13 Jun 2022 22:53:54 +0200,
Hans de Goede wrote:
> 
> Hi,
> 
> On 6/13/22 11:13, Takashi Iwai wrote:
> > On Mon, 13 Jun 2022 10:46:28 +0200,
> > Hans de Goede wrote:
> >>
> >> Hi,
> >>
> >> On 6/13/22 10:28, Takashi Iwai wrote:
> >>> On Mon, 13 Jun 2022 09:54:47 +0200,
> >>> Hans de Goede wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>> There is a problem with the sound on the Lenovo Yoga Duet 7 13IML05, which
> >>>> requires a SND_PCI_QUIRK to fix. But there already is an existing quirk
> >>>> for another Lenovo laptop using the same  PCI subsys vend + prod ids.
> >>>>
> >>>> For more details see:
> >>>> https://wiki.archlinux.org/title/Lenovo_Yoga_Duet_7_13IML05#Audio
> >>>>
> >>>> So I guess this means that we need to add a way to also include a DMI match
> >>>> for SND_PCI_QUIRKs ?
> >>>>
> >>>> Maybe add a:
> >>>>
> >>>> const struct dmi_systemid *dmi_ids;
> >>>>
> >>>> member to struct snd_pci_quirk and a new
> >>>> SND_PCI_QUIRK_DMI macro to set this?
> >>>
> >>> Do both machines have the very same codec?  I couldn't find
> >>> alsa-info.sh output for Duet 7, but at least, C940 seems with ALC298
> >>> (0x10ec0298), judging from
> >>>   https://bugzilla.kernel.org/show_bug.cgi?id=205755
> >>> If Duet 7 has a different codec (e.g. ALC287 0x10ec0287), we can
> >>> distinguish from that.
> >>
> >> I've just asked the reporter of this for alsa-info.sh output.
> >>
> >> So assuming the codec is indeed different how would I go about
> >> fixing this ?
> > 
> > It'll be something like below.
> 
> Thanks.
> 
> The alsa-info.sh output for the Yoga Duet 7 is here:
> 
> http://alsa-project.org/db/?f=5500aa1b489d2ef4ee6ac3ee613f11f3ed8ecfa8
> 
> This confirms that the codec is different, so I've asked
> @nikitashvets to test the below patch you suggested and
> he has confirmed that this fixes things (thank you @nikitashvets).
> 
> Takashi, if you can turn this into a proper patch (-series?)
> and merge it that would be great!

Sure, thanks for quick testing!


Takashi