Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "nikitashvets@flyium.com" <nikitashvets@flyium.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: How to add 2 different SND_PCI_QUIRKs for 2 models with the same PCI subsys vend + prod ids?
Date: Mon, 13 Jun 2022 10:28:24 +0200	[thread overview]
Message-ID: <87k09l7ys7.wl-tiwai@suse.de> (raw)
In-Reply-To: <7e3aa97a-77c9-3367-8929-a86049286d75@redhat.com>

On Mon, 13 Jun 2022 09:54:47 +0200,
Hans de Goede wrote:
> 
> Hi All,
> 
> There is a problem with the sound on the Lenovo Yoga Duet 7 13IML05, which
> requires a SND_PCI_QUIRK to fix. But there already is an existing quirk
> for another Lenovo laptop using the same  PCI subsys vend + prod ids.
> 
> For more details see:
> https://wiki.archlinux.org/title/Lenovo_Yoga_Duet_7_13IML05#Audio
> 
> So I guess this means that we need to add a way to also include a DMI match
> for SND_PCI_QUIRKs ?
> 
> Maybe add a:
> 
> const struct dmi_systemid *dmi_ids;
> 
> member to struct snd_pci_quirk and a new
> SND_PCI_QUIRK_DMI macro to set this?

Do both machines have the very same codec?  I couldn't find
alsa-info.sh output for Duet 7, but at least, C940 seems with ALC298
(0x10ec0298), judging from
  https://bugzilla.kernel.org/show_bug.cgi?id=205755
If Duet 7 has a different codec (e.g. ALC287 0x10ec0287), we can
distinguish from that.


Takashi

  reply	other threads:[~2022-06-13  8:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-13  7:54 How to add 2 different SND_PCI_QUIRKs for 2 models with the same PCI subsys vend + prod ids? Hans de Goede
2022-06-13  8:28 ` Takashi Iwai [this message]
2022-06-13  8:46   ` Hans de Goede
2022-06-13  9:13     ` Takashi Iwai
2022-06-13 20:53       ` Hans de Goede
2022-06-14  5:34         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k09l7ys7.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=hdegoede@redhat.com \
    --cc=nikitashvets@flyium.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox