From: Takashi Iwai <tiwai@suse.de>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/7] ALSA: emu10k1: fix snd_emu1010_fpga_read() input masking for rev2 cards
Date: Fri, 21 Apr 2023 17:32:44 +0200 [thread overview]
Message-ID: <87fs8tqmhv.wl-tiwai@suse.de> (raw)
In-Reply-To: <ZEKq+mMLniMViILZ@ugly>
On Fri, 21 Apr 2023 17:25:46 +0200,
Oswald Buddenhagen wrote:
>
> On Fri, Apr 21, 2023 at 05:14:10PM +0200, Takashi Iwai wrote:
> > On Fri, 21 Apr 2023 16:10:02 +0200,
> > Oswald Buddenhagen wrote:
> >>
> >> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
> >
> > No changelog is no good news.
> > Please give more information.
> >
> i suppose this is a difference in philosophy. i generally refrain from
> covering in the commit message what comments in the patch already
> explain. otherwise it would be just redundant, and i don't like that
> very much.
>
> anyway, i can add some speculation what problems this could have
> theoretically caused.
You didn't explain exactly *WHAT* you fixed, and that's the readers
may be interested more. The summary says merely "fix
snd_emu1010_fpga_read() input masking for rev2 cards". What was
broken beforehand and what was corrected by your patch? The summary
isn't enough for explaining it, but you have more space here.
thanks,
Takashi
next prev parent reply other threads:[~2023-04-21 15:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 14:10 [PATCH 1/7] ALSA: emu10k1: properly assert E-MU FPGA access constaints Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 2/7] ALSA: emu10k1: fix access to Audigy GPIO port Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 3/7] ALSA: emu10k1: fix snd_emu1010_fpga_read() input masking for rev2 cards Oswald Buddenhagen
2023-04-21 15:14 ` Takashi Iwai
2023-04-21 15:25 ` Oswald Buddenhagen
2023-04-21 15:32 ` Takashi Iwai [this message]
2023-04-21 14:10 ` [PATCH 4/7] ALSA: emu10k1: stop doing weird things with HCFG in snd_emu10k1_emu1010_init() Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 5/7] ALSA: emu10k1: remove apparently pointless FPGA reads Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 6/7] ALSA: emu10k1: remove apparently pointless EMU_HANA_OPTION_CARDS reads Oswald Buddenhagen
2023-04-21 14:10 ` [PATCH 7/7] ALSA: emu10k1: remove remaining cruft from snd_emu10k1_emu1010_init() Oswald Buddenhagen
2023-04-22 8:46 ` [PATCH 1/7] ALSA: emu10k1: properly assert E-MU FPGA access constaints Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs8tqmhv.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox