Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: "Sridharan, Ranjani" <ranjani.sridharan@intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH v2 1/7] ASoC: soc-core: remove snd_soc_rtdcom_list
Date: 18 Dec 2019 12:53:00 +0900	[thread overview]
Message-ID: <87fthijnms.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAFQqKeXLbTTpNzL-G3b5rU+6Lq2ytQu9peq4Cw1K2CtGDViVpg@mail.gmail.com>


Hi Sridharan

>     diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
>     index 0bd2cb2..8e49fb8 100644
>     --- a/sound/soc/soc-core.c
>     +++ b/sound/soc/soc-core.c
>     @@ -261,34 +261,18 @@ static inline void snd_soc_debugfs_exit(void)
>      static int snd_soc_rtdcom_add(struct snd_soc_pcm_runtime *rtd,
>                                   struct snd_soc_component *component)
> 
> Morimoto-san, Thanks for this change. This is a lot more intuitive. But may I suggest that we should also possibly consider
> changing the function name above? 
> How about snd_soc_rtd_add_component() maybe?

Nice idea :)
To avoid multi-features in 1 patch, I want to use additional patch for rename.
Is that OK ?
If so, I will post it if Mark applied it.

Thank you for your help !!
Best regards
---
Kuninori Morimoto
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2019-12-18  3:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18  2:44 [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-18  2:45 ` [alsa-devel] [PATCH v2 1/7] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-18  3:31   ` Sridharan, Ranjani
2019-12-18  3:53     ` Kuninori Morimoto [this message]
2019-12-18  2:45 ` [alsa-devel] [PATCH v2 2/7] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-18  3:36   ` Sridharan, Ranjani
2019-12-18  3:59     ` Kuninori Morimoto
2019-12-18 14:54       ` Pierre-Louis Bossart
2019-12-18 17:14         ` Mark Brown
2019-12-18 17:48           ` Pierre-Louis Bossart
2019-12-18 18:06             ` Mark Brown
2019-12-18  2:45 ` [alsa-devel] [PATCH v2 3/7] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2019-12-18  2:46 ` [alsa-devel] [PATCH v2 4/7] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-18  2:46 ` [alsa-devel] [PATCH v2 5/7] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-18  2:47 ` [alsa-devel] [PATCH v2 6/7] ASoC: soc-dapm: add snd_soc_dapm_stream_stop() Kuninori Morimoto
2019-12-18  2:47 ` [alsa-devel] [PATCH v2 7/7] ASoC: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP Kuninori Morimoto
2019-12-18  6:06 ` [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Ranjani Sridharan
2019-12-19  5:57 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fthijnms.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=ranjani.sridharan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox