From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"Sridharan, Ranjani" <ranjani.sridharan@intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH v2 2/7] ASoC: soc-core: care .ignore_suspend for Component suspend
Date: Wed, 18 Dec 2019 08:54:27 -0600 [thread overview]
Message-ID: <bc4cef12-0095-e2af-5c91-63b06d815b8c@linux.intel.com> (raw)
In-Reply-To: <87eex2jnck.wl-kuninori.morimoto.gx@renesas.com>
>> Card dai_link has .ignore_suspend, and ALSA SoC cares it when suspend.
>> For example, like this
>>
>> for_each_card_rtds(card, rtd) {
>> if (rtd->dai_link->ignore_suspend)
>> continue;
>> ...
>> }
>>
>> But in snd_soc_suspend(), it doesn't care about
>> it when suspending Component. This patch cares it.
>>
>> Morimoto-san,
>>
>> I am a bit skeptical about this change but I could be wrong.
>> I am not sure if the ignore_suspend field in the DAI link
>> definitions was meant to be applicable for the components as well.
>> Mark/Takashi would have to confirm this.
Even for dai links, it's not clear to me what .ignore_suspend means.
For Intel machine drivers, the .ignore_suspend flag is used for DMIC
links which may be used in S0ix/D0ix states. I don't believe this works
if there are multiple target states, e.g. you would probably want to
leave the link active in S0ix, but suspend it in S3?
I think the current .ignore_suspend settings only work with the
assumption that applications will close all capture streams before going
to S3.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-12-18 16:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 2:44 [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Kuninori Morimoto
2019-12-18 2:45 ` [alsa-devel] [PATCH v2 1/7] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2019-12-18 3:31 ` Sridharan, Ranjani
2019-12-18 3:53 ` Kuninori Morimoto
2019-12-18 2:45 ` [alsa-devel] [PATCH v2 2/7] ASoC: soc-core: care .ignore_suspend for Component suspend Kuninori Morimoto
2019-12-18 3:36 ` Sridharan, Ranjani
2019-12-18 3:59 ` Kuninori Morimoto
2019-12-18 14:54 ` Pierre-Louis Bossart [this message]
2019-12-18 17:14 ` Mark Brown
2019-12-18 17:48 ` Pierre-Louis Bossart
2019-12-18 18:06 ` Mark Brown
2019-12-18 2:45 ` [alsa-devel] [PATCH v2 3/7] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2019-12-18 2:46 ` [alsa-devel] [PATCH v2 4/7] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2019-12-18 2:46 ` [alsa-devel] [PATCH v2 5/7] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2019-12-18 2:47 ` [alsa-devel] [PATCH v2 6/7] ASoC: soc-dapm: add snd_soc_dapm_stream_stop() Kuninori Morimoto
2019-12-18 2:47 ` [alsa-devel] [PATCH v2 7/7] ASoC: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP Kuninori Morimoto
2019-12-18 6:06 ` [alsa-devel] [PATCH 0/7 v2] ASoC: soc-core cleanup step8 Ranjani Sridharan
2019-12-19 5:57 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc4cef12-0095-e2af-5c91-63b06d815b8c@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=ranjani.sridharan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox